Skip to content

feat(mojaloop/#2092): upgrade nodeJS version for core services - #61

Merged
mdebarros merged 21 commits into
masterfrom
feat/#2092-Upgrade-NodeJS-Version-for-core-services-v2
Jul 25, 2022
Merged

mdebarros merged 21 commits into
masterfrom
feat/#2092-Upgrade-NodeJS-Version-for-core-services-v2

Conversation

@mdebarros

@mdebarros mdebarros commented Jul 22, 2022 •

Copy link
Copy Markdown
Member

feat(mojaloop/[#2092](https://github.com/mdebarros/simulators/issues/2092)): upgrade nodeJS version for core services - mojaloop/project#2092

  • standardised CI scripts
  • updated docker-compose files to work correctly
  • fixed lint issues
  • updated .nvmrc to latest LTS version
  • added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
  • updated gitignore to include test/results and IGNORE patterns
  • updated README with standard auto-release information
  • Fixed imports
  • Cleaned up Package.json
  • replaced release script to use snapshot as this is an EXPERIMENTAL service, and added releaseReplaceTheAboveWhenNotEXPERIMENTAL to indicate the actual script that should replace it once this repo is no longer EXPERIMENTAL
  • replaced npm-audit-resolves with audit-ci and added an applicable audit-ci.jsonc file with an audit allowList as per mojaloop/design-authority-project/issues/92
  • updated readme with updated TODO items to make this service PRODUCTION-READY (i.e. not EXPERIMENTAL)
  • added safeguards for uncaught promises as required by Node v16 or otherwise the process will terminate in such an advent (possibly due to the legacy RXJS dependency)

Notes:

  • Helm chart mountPaths need to be updated from /opt/event-stream-processor to /opt/app as follows:
        volumeMounts:
        - mountPath: /opt/app/config
          name: <deployment-name>

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses /opt/app instead of /opt/event-stream-processor which will impact config mounts.

feat(mojaloop/[[#2092](https://github.com/mdebarros/simulators/issues/2092)](https://github.com/mdebarros/simulators/issues/2092)): upgrade nodeJS version for core services - mojaloop/project#2092
- standardised CI scripts
- updated docker-compose files to work correctly
- fixed lint issues
- updated .nvmrc to latest LTS version
- added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
- updated gitignore to include test/results and IGNORE patterns
- updated README with standard auto-release information
- Fixed imports
- Cleaned up Package.json

Notes:
- Helm chart mountPaths need to be updated from `/opt/TBD` to `/opt/app` as follows:
    ```YAML
        volumeMounts:
        - mountPath: /opt/app/config
          name: <deployment-name>
    ```

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses `/opt/app` instead of `/opt/TBD` which will impact config mounts.
mdebarros added 13 commits July 22, 2022 16:38
- replaced npm-audit-resolves with audit-ci
- updated CI config to reflect the above change
- added audit-ci.jsonc with updated allowList
- updated package.json scripts to reflect the above change
…rvice, and added releaseReplaceTheAboveWhenNotEXPERIMENTAL to indicate the actual script that should replace it once this repo is no loner EXPERIMENTAL
@mdebarros
mdebarros marked this pull request as ready for review July 22, 2022 15:14
kleyow
kleyow previously approved these changes Jul 22, 2022

@kleyow kleyow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kleyow
kleyow previously approved these changes Jul 22, 2022
@mdebarros

mdebarros commented Jul 25, 2022 •

Copy link
Copy Markdown
Member Author

Manual testing of https://github.com/mojaloop/event-stream-processor/releases/tag/v12.0.0-snapshot.6

Screenshot showing NodeJS runtime for EventStreamProcessor:
Screenshot 2022-07-25 at 12 31 50

Screenshot showing Distributed Tracing being processed:
Screenshot 2022-07-25 at 12 32 23

Screenshot showing related Trace Events being indexed into APM index:
Screenshot 2022-07-25 at 12 35 14

Screenshot showing related Audit Events being indexed into Mojaloop index:
Screenshot 2022-07-25 at 12 35 46

@mdebarros

mdebarros commented Jul 25, 2022 •

Copy link
Copy Markdown
Member Author

Manual testing of https://github.com/mojaloop/event-stream-processor/releases/tag/v12.0.0-snapshot.6

....

Re-tested against https://github.com/mojaloop/event-stream-processor/releases/tag/v12.0.0-snapshot.7 with same successful results as only difference was for an updated dev-dependency update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants