feat(mojaloop/#2092): upgrade nodeJS version for core services - #67
Merged
mdebarros merged 9 commits intoMay 19, 2022
Merged
Conversation
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092 - standardised CI scripts - fixed lint issues - updated .nvmrc to latest LTS version - added standard CI scripts/config to package.json: release, snapshot, standard-version, etc - updated gitignore to include test/results and IGNORE patterns - added useUnknownInCatchVariables config to tsconfig to support current code style - updated README with standard auto-release information Notes: - npm-audit-resolver v3.0.0-7 is a candidate release to resolve compatibility with npm v7+ as described in naugtur/npm-audit-resolver#34. This will need to be addressed going forward as `npm run audit:resolve` (i.e. `resolve-audit`) is currently not functioning. As a work-around, we need to manually run the following command `npm audit fix`. The `npm run audit:check` (i.e. `check-audit`) still works as expected. BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092 - Fixed imports - Added 'serialize-error' to ncurc for dep:check to ignore future updates - this is because v9+ only supports ESM loaders and not CJS. This will need to be addressed in a future story. - Aligned jest config to moja standard - Cleaned up Package.json - Added 'prepublishOnly' script to package.json to ensure that dist is build prior to publishing - Updated tsconfig to latest standards
mdebarros
marked this pull request as ready for review
May 19, 2022 08:32
vijayg10
self-requested a review
May 19, 2022 08:53
vijayg10
approved these changes
May 19, 2022
elnyry-sam-k
approved these changes
May 19, 2022
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
Notes:
npm run audit:resolve(i.e.resolve-audit) is currently not functioning. As a work-around, we need to manually run the following commandnpm audit fix. Thenpm run audit:check(i.e.check-audit) still works as expected.BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!