chore: add private:true to prevent npm publish (#4384) - #245
Merged
Merged
Conversation
This service should only publish Docker images to hub.docker.com, not npm packages to npmjs.com. Adding "private": true causes the CircleCI orb's check_npm_private gate to skip the publish_npm job. Refs: mojaloop/project#4384 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gibaros
requested review from
bushjames,
elnyry-sam-k,
shashi165 and
vijayg10
as code owners
March 17, 2026 14:58
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
elnyry-sam-k
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"private": truetopackage.jsonto prevent this service from being published to npmjs.comhub.docker.com/u/mojaloopcheck_npm_privategate will now skip thepublish_npmjobContext
The
mojaloop/buildCircleCI orb always includes bothpublish_npmandpublish_dockerjobs. Thepublish_npmjob gates itself by checking ifpackage.jsonhas"private": true. Without this flag, services with Dockerfiles were incorrectly publishing to both npm and Docker Hub.Refs: mojaloop/project#4384
Test plan
jq '.private' package.jsonreturnstruepublish_npmjob logs "Package is private, skipping job"🤖 Generated with Claude Code