feat: update liquidity check - #899
Merged
Merged
Conversation
added 12 commits
May 11, 2022 20:48
vijayg10
requested review from
elnyry-sam-k,
lewisdaly,
mdebarros,
oderayi,
shashi165 and
vgenev
as code owners
May 16, 2022 13:13
mdebarros
requested changes
May 17, 2022
Co-authored-by: Miguel de Barros <miguel@debarros.me>
mdebarros
requested changes
May 17, 2022
Open
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat:
chore:
fix:
correctly into a object
BREAKING CHANGE: Transfer will be successful only if the payer has settlement account balance. This is the additional check that has been added in this PR. And also the error message is changed for NDC limit check from
PAYER_FSP_INSUFFICIENT_LIQUIDITYtoPAYER_LIMIT_ERROR. Now the error messagePAYER_FSP_INSUFFICIENT_LIQUIDITYoccurs when the payer has insufficient settlement account balance.