refactor(api): единый Response envelope на HTTP boundary - #505
Merged
Conversation
Ibochkarev
force-pushed
the
feat/issue-341-response-envelope
branch
4 times, most recently
from
August 10, 2026 08:50
cbffc7a to
457d63e
Compare
Map processor bridges through Response::fromProcessor so connector Index stops nesting raw getResponse() payloads, and document domain vs HTTP contracts for contributors (#341).
Resolve processors_path via dirname from the trait, and apply PSR spacing after function keywords in manager routes.
Ibochkarev
force-pushed
the
feat/issue-341-response-envelope
branch
from
August 10, 2026 09:09
457d63e to
b9cbfef
Compare
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Сводит Manager/Web API к одному контракту на HTTP boundary:
MiniShop3\Router\Response+HttpStatus.Import/gallery вынесены из fat closures
manager.phpв контроллеры сResponse::fromProcessor. Customer auth на Web использует тот же bridge. ВResponse.phpзафиксирована таблица слоёв (domain MS2-array vs HTTP envelope vs legacy processors).Перекрывает подход #437 (raw
getResponse()→ envelope). Extra-fields CRUD остаётся в #491 / #355.Тип изменений
Связанные Issues
Closes #341
Как это было протестировано?
Локальный CI-гейт (без полной установки MODX/MySQL), PHP lint + smoke + PHPUnit из
.github/workflows/ci.yml:Vue не трогали. PHPStan локально не гоняли (нет
.phpstan-deps); ожидается job CI.composer ci:php)Конфигурация тестирования:
feat/issue-341-response-envelopeЧеклист
composer stan/ CI jobPHPStan)Дополнительные заметки
Контракты (кратко)
Response::*/fromProcessor{success,message,data}fromProcessor, неgetResponse()в routesAC #341
ResponsegetResponse()вconfig/routes/{manager,web}.phpRouter/Response.php+ эта таблицаFollow-up