Актуализация событий компонента - #5
Merged
Merged
Conversation
Старые названия событий: msOnAfterVendorCreate, msOnAfterVendorUpdate, msOnAfterVendorDelete
biz87
reviewed
Mar 10, 2024
| foreach ($ids as $id) { | ||
| /** @var ProcessorResponse $response */ | ||
| $ms3->utils->runProcessor('MiniShop3\\Processors\\Settings\\Vendor\\' . $method, ['id' => $id]); | ||
| $response = $ms3->utils->runProcessor('MiniShop3\\Processors\\Settings\\Vendor\\' . $method, ['id' => $id]); |
Member
There was a problem hiding this comment.
А нужен ли тут $response и последующий return с прерыванием цикла? Как будто если мы массовую процедуру выполняем, нам не нужно прерывание. Пусть один ID будет с ошибкой, зато остальные нормально завершатся..
biz87
pushed a commit
that referenced
this pull request
Apr 20, 2026
#1 TZ shift: DatePicker value is a local Date; toISOString() returned UTC YYYY-MM-DD, which is a day earlier for TZ east of UTC. Introduce formatDateForPost() that uses getFullYear/getMonth/getDate. #4 Class literal: replace the string 'MiniShop3\Model\msCategory' in OptionsController::getTree() with msCategory::class — IDE-refactor safe and consistent with modResource::class nearby. #5 Formatter consistency: CategoryOptionsController::formatRow() now delegates caption merging to OptionLoaderService::mergeCaptionDescription() — same trim semantics as the storefront overlay, so a ' ' override no longer shows in the admin grid while the site still falls back to global.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что оно делает?
Актуализированы названия событий, названия параметров в них в соответствии с утвержденным планом развития компонента.