Skip to content

Correct version comparison in Client.supports_fakeroot.#327

Merged
sergey-serebryakov merged 1 commit into
mlcommons:masterfrom
sergey-serebryakov:bugfix/supports-fakeroot
Aug 2, 2023
Merged

Correct version comparison in Client.supports_fakeroot.#327
sergey-serebryakov merged 1 commit into
mlcommons:masterfrom
sergey-serebryakov:bugfix/supports-fakeroot

Conversation

@sergey-serebryakov

@sergey-serebryakov sergey-serebryakov commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Fixing type error that was caused be comparing wrong types (mlcube_singularity.singularity_client.Version with semver.VersionInfo).

Fixing type error that was caused be comparing wrong types.
@sergey-serebryakov
sergey-serebryakov requested a review from a team as a code owner August 2, 2023 06:16
@github-actions

github-actions Bot commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sergey-serebryakov
sergey-serebryakov merged commit c5f1193 into mlcommons:master Aug 2, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 2, 2023
@sergey-serebryakov
sergey-serebryakov deleted the bugfix/supports-fakeroot branch August 2, 2023 06:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant