Commit that fixes a number of bugs.#302
Merged
sergey-serebryakov merged 1 commit intoApr 10, 2023
Merged
Conversation
- Adding missing help option for the `run` command. - Refactoring `parse_cli_args` function. Instead of many CLI parameters, it accepts two - parsed and unparsed arguments. Parsed arguments are those parsed by tools such as `click` or `argparse`. Unparsed arguments represent mlcube or task arguments. - Removing some unused imports. - Removing `CliParsed.parse_optional_arg` method. Its functionality has been merged into `CliParser.parse_extra_arg` method. - Adding more unit tests for MLCube CLI interface and `mlcube.parser` module. - Updating default values for new Docker and Singularity runners parameters (those that start with `--`). Default value is None now. - Docker runner was correctly processing new parameters (those starting with `--`) - it was ignoring empty values. Singularity runner did not check if parameters were not provided. This commit also fixes this.
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runcommand.parse_cli_argsfunction. Instead of many CLI parameters, it accepts two - parsed and unparsed arguments. Parsed arguments are those parsed by tools such asclickorargparse. Unparsed arguments represent mlcube or task arguments.CliParsed.parse_optional_argmethod. Its functionality has been merged intoCliParser.parse_extra_argmethod.mlcube.parsermodule.--). Default value is None now.--) - it was ignoring empty values. Singularity runner did not check if parameters were not provided. This commit also fixes this.