Skip to content

Add mount options from the CLI#279

Merged
sergey-serebryakov merged 16 commits into
mlcommons:masterfrom
davidjurado:feature/cli_mount
Aug 15, 2023
Merged

Add mount options from the CLI#279
sergey-serebryakov merged 16 commits into
mlcommons:masterfrom
davidjurado:feature/cli_mount

Conversation

@davidjurado

@davidjurado davidjurado commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

This PR contains the feature to define the mount options from the CLI, this will override all mount options for the input parameters specified in the mlcube.yaml.

Example:

 mlcube run --task=hello --mount=ro

@github-actions

github-actions Bot commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@davidjurado davidjurado changed the title Add mount options from the CLI [WIP] Add mount options from the CLI Nov 4, 2022
@davidjurado
davidjurado force-pushed the feature/cli_mount branch 4 times, most recently from 3f46393 to 1fd29f0 Compare November 11, 2022 16:11
@davidjurado davidjurado changed the title [WIP] Add mount options from the CLI Add mount options from the CLI Nov 18, 2022
@davidjurado
davidjurado requested a review from a team as a code owner June 23, 2023 14:39
@davidjurado
davidjurado force-pushed the feature/cli_mount branch 4 times, most recently from 8414d60 to fb198bf Compare June 23, 2023 15:26

@sergey-serebryakov sergey-serebryakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sergey-serebryakov
sergey-serebryakov merged commit 394a301 into mlcommons:master Aug 15, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants