Skip to content

improving testSetValueChangeEvent#26

Merged
aik099 merged 2 commits into
minkphp:masterfrom
oleg-andreyev:improving-testSetValueChangeEvent
Mar 25, 2019
Merged

improving testSetValueChangeEvent#26
aik099 merged 2 commits into
minkphp:masterfrom
oleg-andreyev:improving-testSetValueChangeEvent

Conversation

@oleg-andreyev

Copy link
Copy Markdown
Contributor

While working on minkphp/MinkSelenium2Driver#304 noticed that testSetValueChangeEvent set "text" into <input type=file/>, but does not accept simple text, it only accepts a filename.

Comment thread tests/Js/ChangeEventTest.php Outdated
@robertfausk

Copy link
Copy Markdown
Contributor

Any news on this?
Got stuck on the same issue preventing me to enable this test.

@aik099 aik099 merged commit d208035 into minkphp:master Mar 25, 2019
@aik099

aik099 commented Mar 25, 2019

Copy link
Copy Markdown
Member

Thanks @oleg-andreyev , merged. Totally forgot about this.

Thanks @robertfausk about a reminder.

robertfausk added a commit to robertfausk/driver-testsuite that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants