Skip to content

Support PHP WebDriver 2.0.#289

Closed
jibran wants to merge 1 commit into
minkphp:masterfrom
jibran:webdriver-2.0
Closed

Support PHP WebDriver 2.0.#289
jibran wants to merge 1 commit into
minkphp:masterfrom
jibran:webdriver-2.0

Conversation

@jibran

@jibran jibran commented Jul 1, 2018

Copy link
Copy Markdown

Fixes #288

Signed-off-by: Jibran Ijaz <jibran.ijaz@gmail.com>
@aik099

aik099 commented Jul 1, 2018

Copy link
Copy Markdown
Member

Without fixed builds I can't really see any difference that new WebDriver library version does.

We should really focus on #287 first and then try adding more features.

@jibran jibran mentioned this pull request Jul 1, 2018
@jibran

jibran commented Jul 1, 2018

Copy link
Copy Markdown
Author

I can't really see any difference that new WebDriver library version does.

I think it will fix #254 but yeah, it is not going to be straightforward. Maybe we have to bump major version or add BC layer.

@Techwolf12

Copy link
Copy Markdown

For #254, it is not fuly compatible by just including this:
And I set browser window size to 1440 x 1024 # FeatureMinkContext::iSetBrowserWindowSizeToX()
Notice: Undefined index: size in vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php line 204

I'll check it out

@stof

stof commented Jan 8, 2019

Copy link
Copy Markdown
Member

Closing this in favor of #304

@stof stof closed this Jan 8, 2019
@jibran jibran deleted the webdriver-2.0 branch June 4, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants