Changed logic behind identification of special template values #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

michelebastione merged 2 commits into mini-software:master from michelebastione:issue-833

Feb 26, 2026

Merged

Changed logic behind identification of special template values #928

Minor adjustment

Annotations

12 warnings

src/MiniExcel.Core/WriteAdapters/EnumerableWriteAdapter.cs#L96

Possible null reference argument for parameter 'prop' in 'CellWriteInfo.CellWriteInfo(object? value, int cellIndex, MiniExcelColumnInfo prop)'.

src/MiniExcel.Core/WriteAdapters/EnumerableWriteAdapter.cs#L85

Possible null reference argument for parameter 'key' in 'object IDictionary<string, object>.this[string key]'.

src/MiniExcel.Core/WriteAdapters/MiniExcelDataReaderWriteAdapter.cs#L46

Possible null reference argument for parameter 'name' in 'int IDataRecord.GetOrdinal(string name)'.

src/MiniExcel.Core/DataReader/MiniExcelDataReader.cs#L17

Non-nullable field '_keys' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

src/MiniExcel.Core/DataReader/MiniExcelAsyncDataReader.cs#L19

Non-nullable field '_keys' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

src/MiniExcel.Core/DataReader/MiniExcelDataReaderBase.cs#L20

Nullability of reference types in return type of 'object? MiniExcelDataReaderBase.this[string name].get' doesn't match implicitly implemented member 'object IDataRecord.this[string name].get' (possibly because of nullability attributes).

src/MiniExcel.Core/DataReader/MiniExcelDataReaderBase.cs#L13

Nullability of reference types in return type of 'object? MiniExcelDataReaderBase.this[int i].get' doesn't match implicitly implemented member 'object IDataRecord.this[int i].get' (possibly because of nullability attributes).

src/MiniExcel.Core/DataReader/MiniExcelDataReaderBase.cs#L255

Nullability of reference types in return type of 'object? MiniExcelDataReaderBase.GetValue(int i)' doesn't match implicitly implemented member 'object IDataRecord.GetValue(int i)' (possibly because of nullability attributes).

src/MiniExcel.Core/DataReader/MiniExcelDataReaderBase.cs#L90

Nullability of reference types in return type of 'IDataReader? MiniExcelDataReaderBase.GetData(int i)' doesn't match implicitly implemented member 'IDataReader IDataRecord.GetData(int i)' (possibly because of nullability attributes).

src/MiniExcel.Core/DataReader/MiniExcelAsyncDataReader.cs#L101

'MiniExcelAsyncDataReader.DisposeAsync()' hides inherited member 'MiniExcelDataReaderBase.DisposeAsync()'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.

Cannot build an overlay database because build-mode is set to "undefined" instead of "none". Falling back to creating a normal full database instead.

CodeQL Action v3 will be deprecated in December 2026. Please update all occurrences of the CodeQL Action in your workflow files to v4. For more information, see https://github.blog/changelog/2025-10-28-upcoming-deprecation-of-codeql-action-v3/

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Changed logic behind identification of special template values #928

Uh oh!

Uh oh!

Changed logic behind identification of special template values #928

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...