Check all symbol errors immediately#10
Merged
Merged
Conversation
Since we can't do this at compile time, the next best thing is to make sure all symbols are checked at bootup so that the server doesn't randomly shit itself at runtime due to a rarely used symbol changing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we can't do this at compile time, the next best thing is to make sure all symbols are checked at bootup so that the server doesn't randomly shit itself at runtime due to a rarely used symbol changing.
I don't think there is a good reason to use RTLD_LAZY over RTLD_NOW, particularly considering the size of libraries we're typically dealing with.