Skip to content

Fix logger#2

Open
Creeperface01 wants to merge 1 commit into
minecraft-linux:masterfrom
Creeperface01:master
Open

Fix logger#2
Creeperface01 wants to merge 1 commit into
minecraft-linux:masterfrom
Creeperface01:master

Conversation

@Creeperface01

@Creeperface01 Creeperface01 commented Mar 20, 2020

Copy link
Copy Markdown

Update to version 1.14.32.1

@MCMrARM

MCMrARM commented Mar 21, 2020

Copy link
Copy Markdown
Member

That's a weird change, that I am unable to outright accept without verification.

Can you show any source you based this change on? I'll probably accept it, I'm just curious and don't have IDA open for 1.14.32.1.

@Creeperface01

Copy link
Copy Markdown
Author

The parameter is an enum and afaik enums are represented as longs. At least this fixed the logger for me.

@MCMrARM

MCMrARM commented Mar 23, 2020

Copy link
Copy Markdown
Member

On my computer,

enum Test {
    TestValue
};

int main() {
    std::cout << sizeof(Test) << std::endl;
    return 0;
}

prints 4, so I'm not really sure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants