MILAB-6435: bump hook image base to ubuntu 24.04 LTS#185
Merged
Conversation
Moves the integration-tests hook image off the EOL ubuntu:20.04 base. Verified locally: image builds, aws and shasum run, entrypoint behavior unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the integration-tests
hookimage base from the EOLubuntu:20.04toubuntu:24.04.What
docker/hook/Dockerfile: both stages (aws-installer + final) move toubuntu:24.04.Verification (local)
aws --version->aws-cli/2.35.5 ... exe/x86_64.ubuntu.24.shasum --version->6.04(libdigest-sha-perl installs fine).Follow-up
The image rebuilds via
0-build-docker.yaml(push to master / manual dispatch) producing a new:<sha>tag. Consuming repos must update their pinned hook-image hash for the bump to take effect there.Other ubuntu bases
Checked
docker/:hookwas the only Ubuntu base.git-crypt(alpine) andnginx-spa(nginx-alpine) need no change.Greptile Summary
Bumps the hook Docker image base from the EOL
ubuntu:20.04to the current LTSubuntu:24.04across both build stages (aws-installer and final). No functional changes were made to the entrypoint, installed packages, or AWS CLI installation steps.FROMlines are updated in lockstep, keeping the build consistent between the installer stage and the final image.libdigest-sha-perland the AWS CLI bundled installer are confirmed to work correctly on 24.04 per local verification in the PR description.Confidence Score: 4/5
Safe to merge — the change is a straightforward OS version bump with no logic modifications and local verification already done.
The Dockerfile change is minimal and correct: both build stages consistently move to ubuntu:24.04, and the package list and entrypoint are untouched.
No files require special attention.
Important Files Changed
Reviews (1): Last reviewed commit: "MILAB-6435: bump hook image base to ubun..." | Re-trigger Greptile