🌱 Update crane to consume migtools/pvc-transfer to fix ingre…

[msajidmansoori12]

…ss hostname validation bug

Summary by CodeRabbit

• Chores

  • Updated project references to the current PVC transfer repository location.
  • Refreshed related development and test references to maintain compatibility with the updated module path.
  • No user-facing behavior or functionality changed.

• Documentation

  • Updated repository links and library references throughout the README and development documentation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b995148e-4850-4571-a2d2-06d4eb989491

📥 Commits

Reviewing files that changed from the base of the PR and between b680482 and 4d776b2.

📒 Files selected for processing (4)

• AGENTS.md
• README.md
• docs/development/README.md
• docs/development/architecture.md

---

📝 Walkthrough

Walkthrough

The PR changes PVC transfer imports and documentation from github.com/backube/pvc-transfer to github.com/migtools/pvc-transfer. It also updates the direct dependency to a newer pseudo-version. Runtime logic remains unchanged.

Changes

PVC transfer module update

Layer / File(s)	Summary
Update PVC transfer module references go.mod, cmd/transfer-pvc/transfer-pvc.go, cmd/transfer-pvc/transfer-pvc_test.go	The command and test imports use the github.com/migtools/pvc-transfer path. go.mod declares the updated pseudo-version.
Update repository references AGENTS.md, README.md, docs/development/README.md, docs/development/architecture.md	Project context and development documentation link to migtools/pvc-transfer.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: istein1

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: updating Crane to use migtools/pvc-transfer.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

cmd/transfer-pvc/transfer-pvc_test.go (1)

9-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Confirm regression coverage for the ingress hostname validation fix.

The changed line updates only the rsynctransfer import. The shown TestRestrictedContainersApplyTo test covers rsync command options, not ingress hostname validation. Confirm that cmd/transfer-pvc/transfer-pvc_test.go tests the hostname cases that triggered the bug. If no such test exists, add one before merge.

As per coding guidelines: “Bug fixes should include regression tests when possible.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/transfer-pvc/transfer-pvc_test.go` at line 9, Review the tests in
transfer-pvc_test.go and add regression coverage for the ingress hostname
validation cases that triggered the fix, rather than relying on
TestRestrictedContainersApplyTo, which only verifies rsync options. Exercise
both the affected valid and invalid hostname behavior through the relevant
transfer-pvc validation flow.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@cmd/transfer-pvc/transfer-pvc_test.go`:
- Line 9: Review the tests in transfer-pvc_test.go and add regression coverage
for the ingress hostname validation cases that triggered the fix, rather than
relying on TestRestrictedContainersApplyTo, which only verifies rsync options.
Exercise both the affected valid and invalid hostname behavior through the
relevant transfer-pvc validation flow.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ffea0bdf-56f1-490c-8f67-019f4cfdebb7

📥 Commits

Reviewing files that changed from the base of the PR and between d7d826d and b680482.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (3)

• cmd/transfer-pvc/transfer-pvc.go
• cmd/transfer-pvc/transfer-pvc_test.go
• go.mod

[aufi]

There are few places to be updated in docs:

• README.md:37 — link text and URL backube/pvc-transfer
• AGENTS.md:17 — backube/pvc-transfer - PV migration
• docs/development/README.md:57 — link text and URL backube/pvc-transfer
• docs/development/architecture.md:95 — URL https://github.com/backube/pvc-transfer

Otherwise looks great.

[msajidmansoori12]

/rfr

[msajidmansoori12]

There are few places to be updated in docs:

* README.md:37 — link text and URL [backube/pvc-transfer](https://github.com/backube/pvc-transfer)

* AGENTS.md:17 — backube/pvc-transfer - PV migration

* docs/development/README.md:57 — link text and URL [backube/pvc-transfer](https://github.com/backube/pvc-transfer)

* docs/development/architecture.md:95 — URL https://github.com/backube/pvc-transfer

Otherwise looks great.

@aufi thanks for catching that , I have updated the docs as you suggested , can you please review when you get a chance.

[msajidmansoori12]

Tested on OCP as well , no blockers , the tests passed.

[aufi]

Thanks for the PR, looks perfect.