test(export): add Etiketter column to working-hours export fixture#1661
Merged
Conversation
The shard-a export spec deep-equals the generated Dashboard sheet against this fixture, which still had the pre-#1660 layout. Insert the Etiketter header and an empty cell at index 2 of all 131 data rows, matching the CI ground truth; all other cells verified byte-identical cell-for-cell via the spec's exact sheet_to_json call. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the stable-branch CI failure (run 29926943061): the shard-a Playwright spec compares the generated Dashboard export against a checked-in fixture xlsx that still had the pre-#1660 column layout. This mechanically inserts the "Etiketter" header + empty cells at index 2 (the CI diff's exact ground truth) — every other cell verified unchanged cell-for-cell via the spec's own sheet_to_json call, plus an independent OpenXML-level check.
Why it slipped through #1660: the PR's merge gate accidentally watched the Copilot-review run instead of the .NET workflow run. The other export-adjacent specs (payroll CSV, glsa-3f) assert no xlsx column positions and are unaffected (both passed on the stable run).
🤖 Generated with Claude Code