Use --no-allow for internal bindings to improve static analysis coverage#3686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-bindgen crate will by default generate a blanket
allowattribute as follows:This is convenient as it covers the most common scenarios where Windows APIs violate Rust conventions. It can however mask potential problems that I would prefer to handle directly (and early) where practical for internal uses. So for the internal bindings (dogfood) I have opted to use the
--no-allowoption.I have also removed many of the wrapping
mainfunctions in the crate documentation to avoid the warning from the Clippyneedless_doctest_mainlint.