Forward link macro for raw-dylib support#3670
Merged
Merged
Conversation
This was referenced Jul 28, 2025
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Aug 25, 2025
Summary: I need this for the `windows-targets` crate. Version 0.53.3 in microsoft/windows-rs#3670 introduced the following conditional dependency: ```lang=toml [target.'cfg(windows_raw_dylib)'.dependencies] windows-link = { version = "0.1.3", default-features = false } ``` If a project were to use a fixup like this: ```lang=toml # fixups/windows-targets/fixups.toml cfgs = ["windows_raw_dylib"] ``` then Reindeer needs to know that the `windows-link` dependency applies. Previously, the `cfg(…)` predicate in conditional dependencies was only evaluated based on the cfgs of the platform according to reindeer.toml. Reviewed By: diliop Differential Revision: D80892198 fbshipit-source-id: a0567e99fb97fd8f3cb3fce21334743aacc75381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
windows-targetscrate behaves exactly like the newerwindows-linkcrate whenwindows_raw_dylibis defined. This update just forwards the implementation rather than duplicating the implementation to avoid having to maintain two copies of this tricky code. This shouldn't have much impact in practice since thewindows_raw_dylibis rarely used.