Skip to content

Skip keepAlive flag #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrmarti merged 1 commit into from
Sep 30, 2024
Merged

Skip keepAlive flag #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Change Log
Notable changes will be documented here.

## [TBD]
- Skip keepAlive flag ([microsoft/vscode#228872](https://github.com/microsoft/vscode/issues/228872))

## [0.23.0]
- Pass on keepAlive flag ([microsoft/vscode#173861](https://github.com/microsoft/vscode/issues/173861))

Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ export function createHttpPatch(params: ProxyAgentParams, originals: typeof http
const agent = createPacProxyAgent(resolveP, {
originalAgent: (!useProxySettings || isLocalhost || config === 'fallback') ? originalAgent : undefined,
lookupProxyAuthorization: params.lookupProxyAuthorization,
keepAlive: ((originalAgent || originals.globalAgent) as { keepAlive?: boolean }).keepAlive,
// keepAlive: ((originalAgent || originals.globalAgent) as { keepAlive?: boolean }).keepAlive, // Skipping due to https://github.com/microsoft/vscode/issues/228872.
});
agent.protocol = isHttps ? 'https:' : 'http:';
options.agent = agent
Expand Down
3 changes: 2 additions & 1 deletion tests/test-client/src/direct.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ describe('Direct client', function () {
});
assert.ok(seen, 'Original agent not called!');
});
it('should reuse socket with agent', async function () {
it.skip('should reuse socket with agent', async function () {
// Skipping due to https://github.com/microsoft/vscode/issues/228872.
// https://github.com/microsoft/vscode/issues/173861
const resolveProxy = vpa.createProxyResolver(directProxyAgentParams);
const patchedHttps: typeof https = {
Expand Down