Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Show warning if 'program' attribute is used in 'remote' #2999

Merged
Ramya Rao (ramya-rao-a) merged 3 commits into from
Mar 24, 2020
Merged

Show warning if 'program' attribute is used in 'remote' #2999

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62a4452
Show warning messages for remote mode and program attribute.
quoctruong Mar 23, 2020
0916d33
Remove duplicate
quoctruong Mar 23, 2020
b7ee610
Fix warning logic
quoctruong Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 26 additions & 18 deletions src/goDebugConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,25 +112,33 @@ export class GoDebugConfigurationProvider implements vscode.DebugConfigurationPr
debugConfiguration['currentFile'] =
activeEditor && activeEditor.document.languageId === 'go' && activeEditor.document.fileName;

const neverAgain = { title: `Don't Show Again` };
const ignoreWarningKey = 'ignoreDebugLaunchRemoteWarning';
const ignoreWarning = getFromGlobalState(ignoreWarningKey);
if (
ignoreWarning !== true &&
debugConfiguration.request === 'launch' &&
debugConfiguration['mode'] === 'remote'
) {
vscode.window
.showWarningMessage(
`Request type of 'launch' with mode 'remote' is deprecated, please use request type 'attach' with mode 'remote' instead.`,
neverAgain
)
.then((result) => {
if (result === neverAgain) {
updateGlobalState(ignoreWarningKey, true);
}
});
if (debugConfiguration.request === 'launch' && debugConfiguration['mode'] === 'remote') {
this.showWarning(
'ignoreDebugLaunchRemoteWarning',
`Request type of 'launch' with mode 'remote' is deprecated, please use request type 'attach' with mode 'remote' instead.`);
}

if (debugConfiguration.request === 'attach'
&& debugConfiguration['mode'] === 'remote'
&& debugConfiguration['program']) {
this.showWarning(
'ignoreUsingRemotePathAndProgramWarning',
`Request type of 'attach' with mode 'remote' does not work with 'program' attribute, please use 'cwd' attribute instead.`);
}
return debugConfiguration;
}

private showWarning(ignoreWarningKey: string, warningMessage: string) {
const ignoreWarning = getFromGlobalState(ignoreWarningKey);
if (ignoreWarning) {
return;
}

const neverAgain = { title: 'Don\'t Show Again' };
vscode.window.showWarningMessage(warningMessage, neverAgain).then((result) => {
if (result === neverAgain) {
updateGlobalState(ignoreWarningKey, true);
}
});
}
}