No 'AddResultFile' implementation in TestContext on .NET Core 2.0 test project

[Aecid]

Description

Using .Net Core 2.0 MSTest V2 project - I don't have access to some TestContext methods that are present on .Net Framework project.

Steps to reproduce

Create a .Net Core 2.0 MSTest project. Add TestContext property to a Unit Test class. Try to add a file to a TestContext using TestContext.AddResultFile() method

Expected behavior

There should be such method in TestContext class

Actual behavior

There is no such method in TestContext class

Environment

MSTest V2 1.2.0
.Net Core 2.0

[ShreyasRmsft]

hi Oleksii Priazhnikov (@Aecid),
you are indeed right the implementation for AddResultFile is missing for the net standard implementation of the TestContext Abstract class.

Here is the full CLR implementation

Here is the netstandard implementation that is missing this function

Please feel free to contribute. It's a very small fix and will mostly involve copying the same implementation and maybe adding a UnitTest or two.

I can help you out with the process.

[Aecid]

Ok, I'll try to do this next week, thank you. :)

[parrainc]

Oleksii Priazhnikov (@Aecid) have you started working on this? Or still working on it?
If no, I could take care of it :).
I'm facing the same issue, and I'm needing the AddResultFile method added to the TestContext.

[ShreyasRmsft]

Carlos Parra (@parrainc) let me know if you need any help with the PR once you get started on it.

[parrainc]

thanks Shreyas R (@ShreyasRmsft)
I'm already working on it, will let you know if i get lost with the PR. :)

[parrainc]

Hi Shreyas R (@ShreyasRmsft)

I already implemented the AddResultFile method and GetResultFiles as well, created a couple of unit tests for both methods and pushed the commits to my repo.

But, the implementation for AddResultFile is not the same as in the full CLR implementation you provided, given that apparently the netstandard version used in the Shared project is lower than 1.3 (which not contains Path.GetFullPath() method used to get the absolute path of the file name).

Please, kindly ask you to review [the implementation I've done in my repo] and suggests if there's a way to implement what Path.GetFullPath() method does in a netstandard version lower than 1.3.

I'm just missing that in order to make the PR for this issue :)

Thanks in advanced!!

[stilren]

How would one add a result file to the test results while waiting for this feature?

[ShreyasRmsft]

pvlakshm (@pvlakshm) Prachi Bora (@PBoraMSFT) to answer when this will be picked up from our side.

[drews-ac]

Are there any workarounds or timeline for when this will be merged in?

[drews-ac]

Why can't the caller be responsible for providing the full path?