Skip to content

feat(firefox): support local network permissions #41934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Andrey Lushnikov (aslushnikov) wants to merge 1 commit into from
Closed

feat(firefox): support local network permissions #41934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions packages/playwright-core/src/server/firefox/ffBrowser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,18 +278,19 @@ export class FFBrowserContext extends BrowserContext {
}

async doGrantPermissions(origin: string, permissions: string[]) {
const webPermissionToProtocol = new Map<string, string>([
['geolocation', 'geo'],
['persistent-storage', 'persistent-storage'],
['push', 'push'],
['notifications', 'desktop-notification'],
['screen-wake-lock', 'screen-wake-lock'],
const webPermissionToProtocol = new Map<string, string[]>([
['geolocation', ['geo']],
['persistent-storage', ['persistent-storage']],
['push', ['push']],
['notifications', ['desktop-notification']],
['screen-wake-lock', ['screen-wake-lock']],
['local-network-access', ['local-network', 'loopback-network']],
]);
const filtered = permissions.map(permission => {
const protocolPermission = webPermissionToProtocol.get(permission);
if (!protocolPermission)
const filtered = permissions.flatMap(permission => {
const protocolPermissions = webPermissionToProtocol.get(permission);
if (!protocolPermissions)
throw new Error('Unknown permission: ' + permission);
return protocolPermission;
return protocolPermissions;
});
await this._browser.session.send('Browser.grantPermissions', { origin: origin, browserContextId: this._browserContextId, permissions: filtered });
}
Expand Down
2 changes: 1 addition & 1 deletion tests/library/permissions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ it('local network request is allowed from public origin', {
it.skip(browserName === 'webkit');
it.skip(browserName === 'chromium' && browserMajorVersion < 145, 'local-network-access permission support has changed between versions');

if (browserName === 'chromium')
if (browserName === 'chromium' || browserName === 'firefox')
await context.grantPermissions(['local-network-access']);
const serverRequests = [];
server.setRoute('/cors', (req, res) => {
Expand Down