devops: remove unused driver publishing - #41518
Merged
Merged
Conversation
Co-authored-by: Skn0tt <14912729+Skn0tt@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Skn0tt
June 29, 2026 10:14
View session
dgozman
reviewed
Jun 29, 2026
dgozman
left a comment
dgozman
left a comment
Collaborator
There was a problem hiding this comment.
- Let's also remove
print-api-jsoncli command. - Let's wait until we publish the java port.
Member
|
@copilot can you drop the print-api-json command? |
Co-authored-by: Skn0tt <14912729+Skn0tt@users.noreply.github.com>
Contributor
Author
Dropped the |
dgozman
approved these changes
Jun 30, 2026
dcrousso
added a commit
to dcrousso/playwright-dotnet
that referenced
this pull request
Jul 30, 2026
`roll_driver` read the pinned Node.js version out of `utils/build/build-playwright-driver.sh`, but upstream deleted that script in <microsoft/playwright#41518>, so the roll aborted under `set -e`. fall back to the latest Node.js LTS from <https://nodejs.org/dist/index.json>, matching the policy that upstream `utils/build/update-playwright-node.mjs` now follows. `1.62` removes the per method `timeout` parameter from the protocol and carries the call timeout in the metadata instead, so every timeout silently stopped being honoured. move `timeout` out of the parameters and into the metadata when sending a message, which leaves every existing call site and its default resolution untouched. `IAPIResponse.Timing` and `ILocator.WaitForFunctionAsync` are new in 1.62, so add handwritten implementations to back the generated interfaces. Firefox 153 fixes <microsoft/playwright#38919>, so `WorkersTests` no longer needs its Firefox specific `toLocaleString` expectation.
dcrousso
added a commit
to dcrousso/playwright-dotnet
that referenced
this pull request
Jul 30, 2026
`roll_driver` read the pinned Node.js version out of `utils/build/build-playwright-driver.sh`, but upstream deleted that script in <microsoft/playwright#41518>, so the roll aborted under `set -e`. fall back to the latest Node.js LTS from <https://nodejs.org/dist/index.json>, matching the policy that upstream `utils/build/update-playwright-node.mjs` now follows. `1.62` removes the per method `timeout` parameter from the protocol and carries the call timeout in the metadata instead, so every server dispatched operation timeout silently stopped being honoured. move `timeout` out of the parameters and into the metadata when sending a message, which leaves every existing call site and its default resolution untouched. `IAPIResponse.Timing` and `ILocator.WaitForFunctionAsync` are new in 1.62, so add handwritten implementations to back the generated interfaces. Firefox 153 fixes <microsoft/playwright#38919>, so `WorkersTests` no longer needs its Firefox specific `toLocaleString` expectation. `should work while navigating` took a viewport screenshot where the upstream test it ports takes a full page one, so align it.
dcrousso
added a commit
to dcrousso/playwright-dotnet
that referenced
this pull request
Jul 30, 2026
`roll_driver` read the pinned Node.js version out of `utils/build/build-playwright-driver.sh`, but upstream deleted that script in <microsoft/playwright#41518>, so the roll aborted under `set -e`. read the latest Node.js LTS from <https://nodejs.org/dist/index.json> instead, matching the policy that upstream `utils/build/update-playwright-node.mjs` now follows. `1.62` removes the per method `timeout` parameter from the protocol and carries the call timeout in the metadata instead, so every server dispatched operation timeout silently stopped being honoured. move `timeout` out of the parameters and into the metadata when sending a message, which leaves every existing call site and its default resolution untouched. `IAPIResponse.Timing` and `ILocator.WaitForFunctionAsync` are new in 1.62, so add handwritten implementations to back the generated interfaces. Firefox 153 fixes <microsoft/playwright#38919>, so `WorkersTests` no longer needs its Firefox specific `toLocaleString` expectation. `should work while navigating` took a viewport screenshot where the upstream test it ports takes a full page one, so align it.
dcrousso
added a commit
to dcrousso/playwright-dotnet
that referenced
this pull request
Jul 30, 2026
`roll_driver` read the pinned Node.js version out of `utils/build/build-playwright-driver.sh`, but upstream deleted that script in <microsoft/playwright#41518>, so the roll aborted under `set -e`. read the latest Node.js LTS from <https://nodejs.org/dist/index.json> instead, matching the policy that upstream `utils/build/update-playwright-node.mjs` now follows. `1.62` removes the per method `timeout` parameter from the protocol and carries the call timeout in the metadata instead, so every server dispatched operation timeout silently stopped being honoured. move `timeout` out of the parameters and into the metadata when sending a message, which leaves every existing call site and its default resolution untouched. `IAPIResponse.Timing` and `ILocator.WaitForFunctionAsync` are new in 1.62, so add handwritten implementations to back the generated interfaces. Firefox 153 fixes <microsoft/playwright#38919>, so `WorkersTests` no longer needs its Firefox specific `toLocaleString` expectation. `should work while navigating` took a viewport screenshot where the upstream test it ports takes a full page one, so align it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver distribution is no longer used, so the driver publishing pipeline and its supporting scripts can be removed.
Changes
publish_release.yml: dropped the Azure CDN login +build & publish driversteps; renamed jobpublish-npm-and-driver→publish-npmand removed theallow-publish-driver-to-cdnenvironment (only NPM/trace-viewer publishing remains).utils/build/build-playwright-driver.shandutils/build/upload-playwright-driver.sh.tests_secondary.yml: removed thebuild-playwright-driverCI job.update-playwright-node.mjs: dropped the now-dangling driver build-script version bump; Docker Node.js rolling is unchanged.print-api-jsonCLI command: removed the hidden command and theprintApiJsonhelper fromdriver.ts, along with the now-unusedpath/packageRootimports.