Skip to content

Add Fedora cloud image validation tests part1#4573

Merged
LiliDeng merged 5 commits into
microsoft:mainfrom
balakreddy:fedora_ci_tests_1
Jul 19, 2026
Merged

Add Fedora cloud image validation tests part1#4573
LiliDeng merged 5 commits into
microsoft:mainfrom
balakreddy:fedora_ci_tests_1

Conversation

@balakreddy

@balakreddy balakreddy commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

Adding fedora tests to run on fedora community cloud images using LISA in Azure. These tests are part of Fedora CI moving them to LISA will help us run them on nightly builds on Azure.

  • verify_fedora_edition_identification: Validates /etc/os-release fields, fedora-release package version, SUPPORT_END date, URL accessibility, hostnamectl output, and /etc/fedora-release format
  • verify_services_started: Verifies no systemd services are in failed state after boot

Related Issue

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation update

Checklist

  • Description is filled in above
  • No credentials, secrets, or internal details are included
  • Peer review requested (if not, add required peer reviewers after raising PR)
  • Tests executed and results posted below

Test Validation

Key Test Cases:

Impacted LISA Features:

Tested Azure Marketplace Images:

  • Fedora-5e266ba4-2250-406d-adad-5d73860d958f/Fedora-Cloud-43-x64/latest

Test Results

Image VM Size Result
Fedora-Cloud-43-x64/latest Standard_D2ads_v5 PASSED

- `verify_fedora_edition_identification`: Validates /etc/os-release fields, fedora-release package version, SUPPORT_END date, URL accessibility, hostnamectl output, and /etc/fedora-release format
- `verify_services_started`: Verifies no systemd services are in failed state after boot

Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
@balakreddy
balakreddy requested a review from LiliDeng as a code owner July 1, 2026 19:47
Copilot AI review requested due to automatic review settings July 1, 2026 19:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new LISA test suite to validate Fedora community cloud images in Azure, focusing on Fedora self-identification (/etc/os-release, fedora-release RPM, SUPPORT_END, URLs) and post-boot systemd service health.

Changes:

  • Adds FedoraCloudValidation test suite with Fedora edition identification checks.
  • Adds a boot validation test that checks for failed systemd units after startup.

Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
@balakreddy

Copy link
Copy Markdown
Contributor Author

Adding @jeremycline for PR review.

Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
@balakreddy

Copy link
Copy Markdown
Contributor Author

Adding @nmeyerhans for visibility.

systemctl reports zero failed units.
""",
priority=1,
requirement=simple_requirement(supported_os=[Fedora]),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it's a generally useful test for any image that uses systemd, for what it's worth. I assume Debian and others also expect their base images to have no failed units.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Additionally, there's already code checking systemctl is-system-running in lisa/microsoft/testsuites/kexec/kexec_suite.py. Would probably be worth generalizing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this PR scoped to Fedora for now. Will add Debian support in a follow-up PR

Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
- Add before_case to restrict to fedora only
- Use systemctl -is-system-running as suggested
- Remove Version check, hostnamectl assertion, url validation and
  /etc/fedora-release check

Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
Copilot AI review requested due to automatic review settings July 8, 2026 03:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 9 comments.

Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
Copilot AI review requested due to automatic review settings July 8, 2026 03:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py Outdated
Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
Copilot AI review requested due to automatic review settings July 13, 2026 21:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
@balakreddy
balakreddy requested a review from jeremycline July 14, 2026 20:44

@jeremycline jeremycline left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note, but otherwise it does seem to cover the two Fedora acceptance tests. I can't speak for anything LISA-specific, the things being tested look right to me

Comment thread lisa/microsoft/testsuites/fedora/fedora_cloud_validation.py
@LiliDeng
LiliDeng merged commit 36d88ca into microsoft:main Jul 19, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants