Add Fedora cloud image validation tests part1#4573
Conversation
- `verify_fedora_edition_identification`: Validates /etc/os-release fields, fedora-release package version, SUPPORT_END date, URL accessibility, hostnamectl output, and /etc/fedora-release format - `verify_services_started`: Verifies no systemd services are in failed state after boot Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces a new LISA test suite to validate Fedora community cloud images in Azure, focusing on Fedora self-identification (/etc/os-release, fedora-release RPM, SUPPORT_END, URLs) and post-boot systemd service health.
Changes:
- Adds
FedoraCloudValidationtest suite with Fedora edition identification checks. - Adds a boot validation test that checks for failed systemd units after startup.
Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
|
Adding @jeremycline for PR review. |
|
Adding @nmeyerhans for visibility. |
| systemctl reports zero failed units. | ||
| """, | ||
| priority=1, | ||
| requirement=simple_requirement(supported_os=[Fedora]), |
There was a problem hiding this comment.
This feels like it's a generally useful test for any image that uses systemd, for what it's worth. I assume Debian and others also expect their base images to have no failed units.
There was a problem hiding this comment.
+1. Additionally, there's already code checking systemctl is-system-running in lisa/microsoft/testsuites/kexec/kexec_suite.py. Would probably be worth generalizing.
There was a problem hiding this comment.
Keeping this PR scoped to Fedora for now. Will add Debian support in a follow-up PR
- Add before_case to restrict to fedora only - Use systemctl -is-system-running as suggested - Remove Version check, hostnamectl assertion, url validation and /etc/fedora-release check Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
Signed-off-by: Bala Konda Reddy M <bala12352@gmail.com>
jeremycline
left a comment
There was a problem hiding this comment.
One small note, but otherwise it does seem to cover the two Fedora acceptance tests. I can't speak for anything LISA-specific, the things being tested look right to me
Description
Adding fedora tests to run on fedora community cloud images using LISA in Azure. These tests are part of Fedora CI moving them to LISA will help us run them on nightly builds on Azure.
verify_fedora_edition_identification: Validates /etc/os-release fields, fedora-release package version, SUPPORT_END date, URL accessibility, hostnamectl output, and /etc/fedora-release formatverify_services_started: Verifies no systemd services are in failed state after bootRelated Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results