Skip to content

SKL 1.5.0 changes - #774

Draft
Karla Saur (ksaur) wants to merge 4 commits into
mainfrom
kasaur/skl1.5.0
Draft

SKL 1.5.0 changes#774
Karla Saur (ksaur) wants to merge 4 commits into
mainfrom
kasaur/skl1.5.0

Conversation

@ksaur

@ksaur Karla Saur (ksaur) commented May 30, 2024

Copy link
Copy Markdown
Contributor

@ksaur

Karla Saur (ksaur) commented May 30, 2024

Copy link
Copy Markdown
Contributor Author

Ok the decomposition bug is definitely fixed!

I am a bit confused about the bagging changes (scikit-learn/scikit-learn#28432) I don't see what would have broken our code. Can you please take a look Matteo Interlandi (@interesaaat); I think you know this op best.

=========================== short test summary info ============================
FAILED tests/test_sklearn_bagging.py::TestSklearnBagging::test_bagging_logistic_regression - AssertionError: 
Not equal to tolerance rtol=1e-06, atol=1e-06

Mismatched elements: 200 / 200 (100%)
Max absolute difference: 0.99875297
Max relative difference: 0.99875297
 x: array([[9.809476e-01, 1.905245e-02],
       [9.987530e-01, 1.247026e-03],
       [8.200397e-01, 1.799603e-01],...
 y: array([[0., 1.],
       [0., 1.],
       [0., 1.],...
====== 1 failed, 389 passed, 275 skipped, 59 warnings in 89.85s (0:01:29) ======

It seems that there is some type/rounding issue?

@ksaur Karla Saur (ksaur) added the help wanted Extra attention is needed label May 31, 2024
@ksaur

Copy link
Copy Markdown
Contributor Author

Let's see where we are on this one, i think it's important to unpin this sooner than later. If necessary, we should mark this test as broken and add some warnings then move forward if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAILED tests/test_sklearn_bagging.py::TestSklearnBagging::test_bagging_logistic_regression - AssertionError

1 participant