Skip to content

[dev-v5] Migrate FluentOverlay - #4362

Closed
Marvin Klein (MarvinKlein1508) wants to merge 42 commits into
microsoft:dev-v5from
MarvinKlein1508:migrate-overlay
Closed

[dev-v5] Migrate FluentOverlay#4362
Marvin Klein (MarvinKlein1508) wants to merge 42 commits into
microsoft:dev-v5from
MarvinKlein1508:migrate-overlay

Conversation

@MarvinKlein1508

Copy link
Copy Markdown
Collaborator

This PR is a draft for a first exchange about the component structure. It includes the basic FluentOverlay component and all demos from v4.

I will close this PR after exchange and open a new one once the component is fully ready.

Still missing

  • Tests
  • Code comments
  • Migration guide

Comment thread src/Core/Components/Overlay/FluentOverlay.razor.cs Outdated
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.cs
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.cs
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.cs
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.cs Outdated
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.cs
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.ts
Comment thread src/Core/Microsoft.FluentUI.AspNetCore.Components.csproj Outdated
Comment thread src/Core/Microsoft.FluentUI.AspNetCore.Components.csproj Outdated
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.cs Outdated
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.cs
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.ts Outdated
Comment thread src/Core/Components/Overlay/FluentOverlay.razor.ts Outdated
Comment thread src/Core/Utilities/ZIndex.cs Outdated
@MarvinKlein1508

Copy link
Copy Markdown
Collaborator Author

Denis Voituron (@dvoituron) Vincent Baaij (@vnbaaij) if we stick with the current code then I'm going to prepare remaining tests and documentation.

Comment thread src/Core/Components/Overlay/FluentOverlay.razor.cs
@MarvinKlein1508

Copy link
Copy Markdown
Collaborator Author

I've updated the Transparent parameter to be false by default. This aligns with the removed checks in OnInitialized which set this value to false when an Opacity is provided which by default was provided anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants