[Dialog] Fix error when module hasn't finished loading - #4324
Merged
Vincent Baaij (vnbaaij) merged 2 commits intoNov 17, 2025
Conversation
James Newton-King (JamesNK)
requested review from
Denis Voituron (dvoituron) and
Vincent Baaij (vnbaaij)
as code owners
November 17, 2025 00:25
Member
Author
|
The problem with the TCS approach is displaying a dialog in OnInitialize + await will block OnAfterRenderAsync from being called and will deadlock. |
Member
Author
|
Changed to not track previously selected element if module hasn't been loaded. |
Denis Voituron (dvoituron)
approved these changes
Nov 17, 2025
vnbaaij-hanab
approved these changes
Nov 17, 2025
Vincent Baaij (vnbaaij)
approved these changes
Nov 17, 2025
Vincent Baaij (vnbaaij)
changed the title
This was referenced Nov 28, 2025
Merged
Merged
This was referenced Dec 7, 2025
Merged
This was referenced Dec 22, 2025
Merged
Bump Microsoft.FluentUI.AspNetCore.Components from 4.13.1 to 4.13.2
MWG-Logan/CW-ProjectReporting#37
Merged
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4311