Change the initialization time of Radio button's isChecked - #1312
Merged
Pepe Rivera (joseartrivera) merged 6 commits intoAug 20, 2020
Conversation
Quentin Al-Timimi (quentin987)
self-requested a review
July 13, 2020 16:25
Quentin Al-Timimi (quentin987)
requested review from
Pepe Rivera (joseartrivera)
and removed request for
Quentin Al-Timimi (quentin987)
July 17, 2020 16:52
Lee Won Jun (Lee-WonJun)
force-pushed
the
issue-1303
branch
from
July 21, 2020 14:50
9f675b9 to
d1d5a6a
Compare
Contributor
Author
|
The code was modified as the master branch was changed. |
Pepe Rivera (joseartrivera)
suggested changes
Jul 30, 2020
- In previous versions, there was an issue where button availability was reset when opening BitShift Flyout not when the mode is changed
…e to not Calculator mode" This reverts commit a0d2f84.
Lee Won Jun (Lee-WonJun)
marked this pull request as draft
August 7, 2020 03:12
Lee Won Jun (Lee-WonJun)
marked this pull request as ready for review
August 7, 2020 03:12
Pepe Rivera (joseartrivera)
suggested changes
Aug 12, 2020
Pepe Rivera (joseartrivera)
left a comment
Contributor
There was a problem hiding this comment.
One more change I noticed and then it should be good to go!
Pepe Rivera (joseartrivera)
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the initialization time of Radio button's isChecked in CalculatorProgrammerRadixOperators
Fixes #1303
Description of the changes:
How changes were validated:
Information
As a result of analyzing the call point of g.hpp made from C++, it was confirmed that the theme radio button in Graphing Setting is changed suddenly when CalcuatorProgrammerRadixOperators is initialized.
It was determined that there was something wrong with the components of the CalacuatorProgrammerRadixOperators, and after various tests, it was confirmed that there was a problem in the initialization of the Radio Button (BitshiftFlyout).
The problem I am assuming is as follows.
Excepted

Error

I chose a simple way to check the radio button when displaying the BitShiftFlyout.
So, I added a member variable for saving what is selected. (I just use the reference of radio directly, not use others like enum. this is dangerous?)
I don't think this is the best way. I think this is not a fundamental solution
However, to solve the problem without structural changes (or changing the internal operation), I selected this way.
Additional context
#1310 issue has not been answered yet and has been excluded from the PR.