Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Support extracting more modelTypeId in luis:test command #1229

Merged
Shuai Wang (cosmicshuai) merged 5 commits into from
May 18, 2021
Merged

Support extracting more modelTypeId in luis:test command #1229

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
743784c
support all modelTypeId
cosmicshuai May 6, 2021
63baca6
change valid modelTypeId
cosmicshuai May 7, 2021
560428d
Merge branch 'main' into shuwan/testLuisTest
May 17, 2021
dc130c9
modify test
cosmicshuai May 18, 2021
21dd36c
retrigger
cosmicshuai May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/lu/src/parser/test/testhelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function compareEntity(predictedEntities: any[], utterance: any) {
let pass = true
for (const entity of utterance.entities) {
if (!predictedEntities.find((x: any) =>
(entity.role !== undefined && entity.role === x.role || entity.role === undefined && entity.entity === x.entity)
((entity.role !== undefined && entity.role === x.role) || (entity.role === undefined && entity.entity === x.entity))
&& entity.startPos === x.startPos
&& entity.endPos === x.endPos)) {
pass = false
Expand All @@ -105,7 +105,7 @@ function ParseEntitiyResult(entities: any, result: any) {
if (name === '$instance') {
for (const entityType of Object.keys(entities.$instance)) {
for (const entity of entities.$instance[entityType]) {
if (entity.modelTypeId === 1 || entity.modelTypeId === 4 || (entity.role !== undefined && entity.role !== '')) {
if (entity.modelTypeId === 1 || entity.modelTypeId === 4 || entity.modelTypeId === 10 || entity.role) {
let newEntity: any = new Object()
newEntity.entity = entityType
newEntity.startPos = entity.startIndex
Expand Down