Skip to content

Included curl and grep in all core packages.#5762

Merged
PawelWMS merged 2 commits into
microsoft:mainfrom
PawelWMS:pawelwi/updating_core-packages
Jun 28, 2023
Merged

Included curl and grep in all core packages.#5762
PawelWMS merged 2 commits into
microsoft:mainfrom
PawelWMS:pawelwi/updating_core-packages

Conversation

@PawelWMS

Copy link
Copy Markdown
Contributor
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Moving curl out of core-packages-base-image and into core-packages-container. Recent TDNF upgrade removed the TDNF -> cURL dependency, which was pulling in cURL even for container builds. After the update the base container image lost cURL and that introduced a regression for our users. Since that's a basic tool for many users, we're moving it.

I'm also doing the same thing for grep, which already is part of our container images but was not mentioned explicitly and could have suffered the same fate as curl.

Change Log
  • Moved curl and grep into the core-packages-container package.
Does this affect the toolchain?

No.

Test Methodology
  • Local package build.

@PawelWMS PawelWMS requested a review from a team as a code owner June 28, 2023 17:04
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Jun 28, 2023
Comment thread SPECS/core-packages/core-packages.spec
@PawelWMS PawelWMS merged commit c240172 into microsoft:main Jun 28, 2023
@PawelWMS PawelWMS deleted the pawelwi/updating_core-packages branch June 28, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants