Included curl and grep in all core packages.#5762
Merged
PawelWMS merged 2 commits intoJun 28, 2023
Merged
Conversation
mandeepsplaha
approved these changes
Jun 28, 2023
anphel31
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Moving
curlout ofcore-packages-base-imageand intocore-packages-container. Recent TDNF upgrade removed the TDNF -> cURL dependency, which was pulling in cURL even for container builds. After the update the base container image lost cURL and that introduced a regression for our users. Since that's a basic tool for many users, we're moving it.I'm also doing the same thing for
grep, which already is part of our container images but was not mentioned explicitly and could have suffered the same fate ascurl.Change Log
curlandgrepinto thecore-packages-containerpackage.Does this affect the toolchain?
No.
Test Methodology