Skip to content

Unified fmt.Error formatting with Go's conventions.#5746

Merged
PawelWMS merged 4 commits into
microsoft:mainfrom
PawelWMS:pawelwi/error_clean-up
Jun 29, 2023
Merged

Unified fmt.Error formatting with Go's conventions.#5746
PawelWMS merged 4 commits into
microsoft:mainfrom
PawelWMS:pawelwi/error_clean-up

Conversation

@PawelWMS

@PawelWMS PawelWMS commented Jun 27, 2023

Copy link
Copy Markdown
Contributor
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Adjusted some of our fmt.Error* logs to keep them consistent and align them with the linter's suggestions we kept as a convention.

Change Log
  • Refactored fmt.Error* messages by removing periods at the end and making them start with lowercase letters.
Does this affect the toolchain?

No.

Test Methodology
  • N/A, single character change to a few logs.

@PawelWMS PawelWMS requested a review from a team as a code owner June 27, 2023 17:52
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Jun 27, 2023
Comment thread toolkit/tools/imagegen/configuration/kernelcommandline.go
@PawelWMS PawelWMS merged commit 0628747 into microsoft:main Jun 29, 2023
@PawelWMS PawelWMS deleted the pawelwi/error_clean-up branch June 29, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants