Skip to content

containerized-data-importer: Add nbkdit as a dependency for the importer#5745

Merged
vinceaperri merged 1 commit into
mainfrom
viperri/cdi-importer-nbdkit
Jun 27, 2023
Merged

containerized-data-importer: Add nbkdit as a dependency for the importer#5745
vinceaperri merged 1 commit into
mainfrom
viperri/cdi-importer-nbdkit

Conversation

@vinceaperri

@vinceaperri vinceaperri commented Jun 27, 2023

Copy link
Copy Markdown
Contributor
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Add nbkdit as a dependency for the importer in containerized-data-importer package. This can be done now that nbdkit has been promoted from SPECS-EXTENDED/ to SPECS/.

Change Log
  • containerized-data-importer: Add nbkdit as a dependency for the importer
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: 385118

@vinceaperri vinceaperri requested a review from a team as a code owner June 27, 2023 17:04
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Jun 27, 2023
@vinceaperri vinceaperri force-pushed the viperri/cdi-importer-nbdkit branch from 077a97d to 03a0dbf Compare June 27, 2023 17:41
@vinceaperri vinceaperri force-pushed the viperri/cdi-importer-nbdkit branch from 03a0dbf to 9798f54 Compare June 27, 2023 17:41
@vinceaperri vinceaperri merged commit 90abe4a into main Jun 27, 2023
@vinceaperri vinceaperri deleted the viperri/cdi-importer-nbdkit branch June 27, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants