Add package fsverity-utils#5732
Conversation
|
|
||
| %changelog | ||
| * Thu Apr 20 2023 Elaheh Dehghani <edehghani@microsoft.com> - 1.4-8 | ||
| - Initial overlake-packages import from Fedora 36 (license: MIT). |
There was a problem hiding this comment.
Why not use the latest version of Fedora?
There was a problem hiding this comment.
sorry, don't know the reason...but looks there are no change between Fedora 36 and latest (https://src.fedoraproject.org/rpms/fsverity-utils/blob/f38/f/fsverity-utils.spec)
There was a problem hiding this comment.
should I update the import from Fedora 36 to 38?
There was a problem hiding this comment.
It's fine to keep it as Fedora 36, in that case.
oliviacrain
left a comment
oliviacrain
left a comment
There was a problem hiding this comment.
Looks great- approved with a small suggestion
Buddy build results: Package builds, all tests pass for both architectures
| %make_build CFLAGS="$CFLAGS -g" USE_SHARED_LIB=1 | ||
|
|
||
| %install | ||
| %make_install PREFIX=%{_prefix} LIBDIR=%{_libdir} CFLAGS="$CFLAGS -g" USE_SHARED_LIB=1 |
There was a problem hiding this comment.
Nit: -g is already part of our default set of compiler flags.
| %make_install PREFIX=%{_prefix} LIBDIR=%{_libdir} CFLAGS="$CFLAGS -g" USE_SHARED_LIB=1 | |
| %make_install PREFIX=%{_prefix} LIBDIR=%{_libdir} USE_SHARED_LIB=1 |
| %autosetup -p1 | ||
|
|
||
| %build | ||
| %make_build CFLAGS="$CFLAGS -g" USE_SHARED_LIB=1 |
There was a problem hiding this comment.
Nit: -g is already part of our default set of compiler flags.
| %make_build CFLAGS="$CFLAGS -g" USE_SHARED_LIB=1 | |
| %make_build USE_SHARED_LIB=1 |
3 participants
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Required package to work in overlake project
Change Log
Does this affect the toolchain?
YES/NO
No
Associated issues
Test Methodology