Skip to content

Patching graphviz dot to png error#5717

Merged
osamaesmailmsft merged 7 commits into
mainfrom
osamaesmail/patch_graphviz
Jun 26, 2023
Merged

Patching graphviz dot to png error#5717
osamaesmailmsft merged 7 commits into
mainfrom
osamaesmail/patch_graphviz

Conversation

@osamaesmailmsft

@osamaesmailmsft osamaesmailmsft commented Jun 20, 2023

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
This adds freefont to graphviz-gd & fontconfig to freefont to address the issue of converting dot files to png. Graphviz still puts an error out about not having URW fonts, but that doesn't impact function/performance.

Change Log
  • Added freefont to BuildRequires for graphviz-gd
  • Added fontconfig to BuildRequires for freefont and run fc-cache after installing fonts
Does this affect the toolchain?

NO

Test Methodology
  • Pipeline build id: 381379 (Running right now)

@osamaesmailmsft osamaesmailmsft requested a review from a team as a code owner June 20, 2023 18:31
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Jun 20, 2023
@osamaesmailmsft osamaesmailmsft changed the title Osamaesmail/patch graphviz Patching graphviz dot to png error Jun 20, 2023
Comment thread SPECS/freefont/freefont.spec Outdated
Comment thread SPECS/graphviz/graphviz.spec Outdated
Comment thread SPECS/freefont/freefont.spec Outdated
Comment thread SPECS/freefont/freefont.spec Outdated
Comment thread SPECS/graphviz/graphviz.spec Outdated
@osamaesmailmsft osamaesmailmsft merged commit 936ac8d into main Jun 26, 2023
@osamaesmailmsft osamaesmailmsft deleted the osamaesmail/patch_graphviz branch June 26, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants