Adding sriov-network-device-plugin spec file#4005
Merged
Merged
Conversation
10177fd to
d982b7a
Compare
f94de30 to
7cb873a
Compare
romoh
reviewed
Oct 17, 2022
oliviacrain
reviewed
Oct 18, 2022
romoh
approved these changes
Oct 18, 2022
liulanze
approved these changes
Oct 19, 2022
oliviacrain
suggested changes
Oct 20, 2022
43abf02 to
85a8ed7
Compare
oliviacrain
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/tools/cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Added sriov-network-device-plugin rpm to mariner. This will be leveraged by the ECF BFG team.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology
Validated locally by using the local build command:
sudo make build-packages -j8 PACKAGE_BUILD_LIST="sriov-network-device-plugin" PACKAGE_REBUILD_LIST="sriov-network-device-plugin" CONFIG_FILE= REBUILD_TOOLS=y REBUILD_TOOLCHAIN=n REBUILD_PACKAGES=y SOURCE_URL="https://cblmarinerstorage.blob.core.windows.net/sources/core" SRPM_FILE_SIGNATURE_HANDLING=update TOOLCHAIN_ARCHIVE=toolchain_built_rpms_all.tar.gzThis successfully built the rpm with the following output:
INFO[0398] Building sriov-network-device-plugin-3.3-1.cm2.src.rpm INFO[0432] Built: sriov-network-device-plugin-3.3-1.cm2.src.rpm -> [/home/aditya/Desktop/CBL-Mariner/out/RPMS/x86_64/sriov-network-device-plugin-3.3-1.cm2.x86_64.rpm /home/aditya/Desktop/CBL-INFO[0002] Building sriov-network-device-plugin-3.4.0-1.cm2.src.rpm INFO[0040] Built: sriov-network-device-plugin-3.4.0-1.cm2.src.rpm -> [/home/aditya/Desktop/CBL-Mariner/out/RPMS/x86_64/sriov-network-device-plugin-3.4.0-1.cm2.x86_64.rpm /home/aditya/Desktop/CBL-Mariner/out/RPMS/x86_64/sriov-network-device-plugin-debuginfo-3.4.0-1.cm2.x86_64.rpm] INFO[0040] 0 currently active build(s): []. INFO[0040] All packages built INFO[0041] --------------------------- INFO[0041] --------- Summary --------- INFO[0041] --------------------------- INFO[0041] Number of built SRPMs: 1 INFO[0041] Number of prebuilt SRPMs: 9 INFO[0041] Number of failed SRPMs: 0 INFO[0041] Number of blocked SRPMs: 0 INFO[0041] Number of unresolved dependencies: 0 INFO[0041] Number of toolchain RPM conflicts: 0 INFO[0041] Number of toolchain SRPM conflicts: 0 INFO[0041] Built SRPMs: INFO[0041] --> sriov-network-device-plugin-3.4.0-1.cm2.src.rpmAlso validated this on the BuddyBuild-Spec Pipeline build id: 4005