Skip to content

Adding sriov-network-device-plugin spec file#4005

Merged
Adub17030MS merged 17 commits into
mainfrom
adityadubey/sriov-network-device-plugin
Oct 26, 2022
Merged

Adding sriov-network-device-plugin spec file#4005
Adub17030MS merged 17 commits into
mainfrom
adityadubey/sriov-network-device-plugin

Conversation

@Adub17030MS

@Adub17030MS Adub17030MS commented Oct 12, 2022

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Added sriov-network-device-plugin rpm to mariner. This will be leveraged by the ECF BFG team.

Change Log
  • Original version for CBL-Mariner
  • License Verified
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Validated locally by using the local build command:
    sudo make build-packages -j8 PACKAGE_BUILD_LIST="sriov-network-device-plugin" PACKAGE_REBUILD_LIST="sriov-network-device-plugin" CONFIG_FILE= REBUILD_TOOLS=y REBUILD_TOOLCHAIN=n REBUILD_PACKAGES=y SOURCE_URL="https://cblmarinerstorage.blob.core.windows.net/sources/core" SRPM_FILE_SIGNATURE_HANDLING=update TOOLCHAIN_ARCHIVE=toolchain_built_rpms_all.tar.gz
    This successfully built the rpm with the following output:
    INFO[0398] Building sriov-network-device-plugin-3.3-1.cm2.src.rpm INFO[0432] Built: sriov-network-device-plugin-3.3-1.cm2.src.rpm -> [/home/aditya/Desktop/CBL-Mariner/out/RPMS/x86_64/sriov-network-device-plugin-3.3-1.cm2.x86_64.rpm /home/aditya/Desktop/CBL-INFO[0002] Building sriov-network-device-plugin-3.4.0-1.cm2.src.rpm INFO[0040] Built: sriov-network-device-plugin-3.4.0-1.cm2.src.rpm -> [/home/aditya/Desktop/CBL-Mariner/out/RPMS/x86_64/sriov-network-device-plugin-3.4.0-1.cm2.x86_64.rpm /home/aditya/Desktop/CBL-Mariner/out/RPMS/x86_64/sriov-network-device-plugin-debuginfo-3.4.0-1.cm2.x86_64.rpm] INFO[0040] 0 currently active build(s): []. INFO[0040] All packages built INFO[0041] --------------------------- INFO[0041] --------- Summary --------- INFO[0041] --------------------------- INFO[0041] Number of built SRPMs: 1 INFO[0041] Number of prebuilt SRPMs: 9 INFO[0041] Number of failed SRPMs: 0 INFO[0041] Number of blocked SRPMs: 0 INFO[0041] Number of unresolved dependencies: 0 INFO[0041] Number of toolchain RPM conflicts: 0 INFO[0041] Number of toolchain SRPM conflicts: 0 INFO[0041] Built SRPMs: INFO[0041] --> sriov-network-device-plugin-3.4.0-1.cm2.src.rpm

  • Also validated this on the BuddyBuild-Spec Pipeline build id: 4005

@ghost ghost added the main PR Destined for main label Oct 12, 2022
@Adub17030MS Adub17030MS force-pushed the adityadubey/sriov-network-device-plugin branch from 10177fd to d982b7a Compare October 17, 2022 20:54
@Adub17030MS Adub17030MS marked this pull request as ready for review October 17, 2022 20:57
@Adub17030MS Adub17030MS requested a review from a team as a code owner October 17, 2022 20:57
@Adub17030MS Adub17030MS force-pushed the adityadubey/sriov-network-device-plugin branch from f94de30 to 7cb873a Compare October 17, 2022 22:22
Comment thread SPECS/sriov-network-device-plugin/sriov-network-device-plugin.spec
Comment thread SPECS/sriov-network-device-plugin/sriov-network-device-plugin.spec Outdated
Comment thread SPECS/sriov-network-device-plugin/sriov-network-device-plugin.spec Outdated
Comment thread SPECS/sriov-network-device-plugin/sriov-network-device-plugin.spec Outdated
@Adub17030MS Adub17030MS force-pushed the adityadubey/sriov-network-device-plugin branch from 43abf02 to 85a8ed7 Compare October 26, 2022 19:03
Comment thread SPECS/sriov-network-device-plugin/sriov-network-device-plugin.spec
@Adub17030MS Adub17030MS merged commit e5b1260 into main Oct 26, 2022
@Adub17030MS Adub17030MS deleted the adityadubey/sriov-network-device-plugin branch October 26, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants