Force async execution of resource startup - #10359
Merged
Merged
Conversation
- Previously we didn't preemptively dispatch to the threadpool per resource on startup. That causes issues blocking other resource's startup because of a single blocking call. This change dispatching preemptively before creating the dcp resource.
David Fowler (davidfowl)
requested review from
Copilot,
Karol Zadora-Przylecki (karolz-ms) and
Mitch Denny (mitchdenny)
and removed request for
Copilot
July 13, 2025 01:40
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that each resource startup dispatches asynchronously to avoid blocking other resources by preemptively yielding to the thread pool.
- Inserted
Task.Yield()at the start ofCreateExecutableAsyncto force asynchronous execution. - Inserted
Task.Yield()at the start ofCreateContainerAsyncto force asynchronous execution.
Comments suppressed due to low confidence (2)
src/Aspire.Hosting/Dcp/DcpExecutor.cs:1100
- [nitpick] Consider elaborating this comment to explain why
Task.Yield()is necessary to prevent blocking other resource startups (e.g., avoiding thread-pool starvation).
// Force async execution
src/Aspire.Hosting/Dcp/DcpExecutor.cs:1354
- [nitpick] Consider expanding this comment to detail the rationale for forcing an asynchronous yield here, so future readers understand the threading implications.
// Force async execution
github-actions
Bot
added
the
area-app-model
Mitch Denny (mitchdenny)
approved these changes
Jul 13, 2025
Contributor
Author
|
/backport to release/9.4 |
Contributor
|
Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16244106437 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #10354
Reproduced while dogfooding the community toolkit with 9.4 builds. Verified this fix on the same build.
Hanging stack: