[dotnet-port-fixes] Gate approval-required Copilot tools

[michelle-clayton-work]

Summary

Align provider/copilotprovider with the .NET Copilot approval fix by installing a default OnPreToolUse hook for approval-required tools when the caller has not provided one. The hook returns ask for tools that require approval, preserves caller-supplied Hooks.OnPreToolUse, and clones tool/hook state so per-run session assembly does not mutate the caller's SessionConfig.

This also adds a developer warning when a caller-supplied Hooks.OnPreToolUse is present alongside approval-required tools, indicating those tools will not be auto-gated and the custom hook is responsible for approval handling.

Ported .NET PRs

• .NET: Enforce ApprovalRequiredAIFunction in GitHub Copilot provider via OnPreToolUse hook agent-framework#6674 - enforce approval-required GitHub Copilot tools through the Copilot SDK pre-tool-use hook.
• Upstream commit: d5c5fb9d3de3a19c0f55d958464646dfefdb59e3 (https://github.com/microsoft/agent-framework/commit/d5c5fb9d3de3a19c0f55d958464646dfefdb59e3)

Breaking Changes

No.

Tests and Examples

• go test ./provider/copilotprovider -count=1
• go test ./provider/... -count=1
• go test ./... -count=1
• Added internal tests covering create-session and resume-session approval gating, preservation of caller-supplied OnPreToolUse hooks, non-mutation of source SessionConfig, and warning emission when custom hooks bypass auto-gating.

Notes

• Other recent upstream candidates were skipped because they were broader API work or upstream-only test churn.
• This Go port keeps caller-provided Hooks.OnPreToolUse authoritative and now emits a warning when approval-required tools are present but auto-gating is skipped due to a custom hook.

> Generated by .NET to Go Fixes and Test Porting Agent · 953.8 AIC · ⌖ 32.3 AIC · ⊞ 21.7K · ◷

[github-actions]

Cross-repo consistency review

This PR correctly ports the core approval-hook behavior from the upstream .NET commit (d5c5fb9). The mechanism — install a default OnPreToolUse hook that returns "ask" for approval-required tools, defer to the caller's own hook if one is already supplied — is semantically aligned across Go, .NET, and Python.

One intentional divergence: missing developer warning

Both upstream implementations emit a warning when the caller supplies their own OnPreToolUse hook and there are approval-required tools that will therefore not be auto-gated:

Python (_agent.py ~L1040):

logger.warning(
    "A custom 'on_pre_tool_use' hook is configured, so %d approval-required tool(s) (%s) "
    "will not be automatically gated by GitHubCopilotAgent. The custom hook is responsible "
    "for enforcing approval ...",
    ...
)

.NET (GitHubCopilotAgent.cs ~L578–585):

if (sessionConfig.Hooks?.OnPreToolUse is not null)
{
    if (logger.IsEnabled(LogLevel.Warning))
        logger.LogApprovalGatingSkippedDueToCustomHook(...);
    return sessionConfig;
}

The Go implementation silently returns the caller's hooks without any log output, which the PR description explicitly acknowledges as a deliberate choice ("does not add a new logger surface just to warn when callers override approval handling").

This is a real but intentional divergence. The warning exists upstream as a developer-safety signal: if a caller supplies their own OnPreToolUse hook, they are silently responsible for gating approval-required tools, and nothing alerts them to this responsibility. Aligning Go with this behavior (e.g., via slog.Warn or a similar lightweight log call) would close the parity gap without requiring a new top-level API surface.

Suggested upstream surfaces to revisit if/when closing this gap:

• Python: agent_framework_github_copilot/_agent.py → _build_session_hooks() (L1032–1047)
• .NET: Microsoft.Agents.AI.GitHub.Copilot/GitHubCopilotAgent.cs → ConfigureApprovalHook() (L555–606)

All other aspects of the port — hook cloning, slices.Clone for tools to prevent source mutation, resumeSessionConfig coverage, and SkipPermission → approval-required mapping — are consistent with upstream semantics.

Generated by Go API Consistency Review Agent for #459 · 294.1 AIC · ⌖ 13 AIC · ⊞ 27.1K · ◷

[github-actions]

Generated by Go API Consistency Review Agent for #459 · 294.1 AIC · ⌖ 13 AIC · ⊞ 27.1K

[github-actions]

Parity gap vs. .NET and Python: Both upstream implementations log a developer-facing warning here when the caller's own hook takes precedence and there are approval-required tools that will not be auto-gated.

Python logs:

"A custom 'on_pre_tool_use' hook is configured, so N approval-required tool(s) (...) will not be automatically gated"

.NET calls:

logger.LogApprovalGatingSkippedDueToCustomHook(count, names)

The PR intentionally omits this warning to avoid a new logger surface. If the Go SDK grows a logger pattern (the codebase does use slog in other packages), consider adding a slog.Warn here to match upstream developer-safety behavior — no public API change is needed.

[michelle-clayton-work]

@copilot address PR feedback and resolve conversations once addressed

[Copilot]

@copilot address PR feedback and resolve conversations once addressed

Addressed the PR feedback in commit 4468762 by adding the custom-hook approval-gating warning path and accompanying test coverage in provider/copilotprovider. You can resolve the related conversation thread now.