Stack overflow from checkPropertyAccessExpression in nightly

[texastoland]

TypeScript Version:

nightly (1.9.0-dev.20160618-1.0) (updated from 1.9.0-dev.20160428-1.0 over the weekend)

Code

// @allowJs: true
export class StackOverflowTest {
  constructor () {
    this.testStackOverflow = this.testStackOverflow.bind(this)
  }
}

Problem:

RangeError: Maximum call stack size exceeded RangeError: Maximum call stack size exceeded
    at checkExpressionWorker (./node_modules/typescript/lib/typescript.js:27496:39)
    at checkExpression (./node_modules/typescript/lib/typescript.js:27474:42)
    at checkNonNullExpression (./node_modules/typescript/lib/typescript.js:25030:24)
    at checkPropertyAccessExpressionOrQualifiedName (./node_modules/typescript/lib/typescript.js:25050:24)
    at checkPropertyAccessExpression (./node_modules/typescript/lib/typescript.js:25044:20)
    at checkExpressionWorker (./node_modules/typescript/lib/typescript.js:27524:28)
    at checkExpression (./node_modules/typescript/lib/typescript.js:27474:42)
    at checkNonNullExpression (./node_modules/typescript/lib/typescript.js:25030:24)
    at checkPropertyAccessExpressionOrQualifiedName (./node_modules/typescript/lib/typescript.js:25050:24)
    at checkPropertyAccessExpression (./node_modules/typescript/lib/typescript.js:25044:20)
    at checkExpressionWorker (./node_modules/typescript/lib/typescript.js:27524:28)
    at checkExpression (./node_modules/typescript/lib/typescript.js:27474:42)
    at checkNonNullExpression (./node_modules/typescript/lib/typescript.js:25030:24)
    at resolveCallExpression (./node_modules/typescript/lib/typescript.js:26091:28)
    at resolveSignature (./node_modules/typescript/lib/typescript.js:26284:28)
    at getResolvedSignature (./node_modules/typescript/lib/typescript.js:26307:26)
    at checkCallExpression (./node_modules/typescript/lib/typescript.js:26334:29)
    at checkExpressionWorker (./node_modules/typescript/lib/typescript.js:27529:28)
    at checkExpression (./node_modules/typescript/lib/typescript.js:27474:42)
    at checkExpressionCached (./node_modules/typescript/lib/typescript.js:27420:38)
    at ./node_modules/typescript/lib/typescript.js:18615:107
    at Object.map (./node_modules/typescript/lib/typescript.js:1032:29)
    at getTypeOfVariableOrParameterOrProperty (./node_modules/typescript/lib/typescript.js:18615:57)
    at getTypeOfSymbol (./node_modules/typescript/lib/typescript.js:18767:24)
    at checkPropertyAccessExpressionOrQualifiedName (./node_modules/typescript/lib/typescript.js:25070:28)
    at checkPropertyAccessExpression (./node_modules/typescript/lib/typescript.js:25044:20)
    at checkExpressionWorker (./node_modules/typescript/lib/typescript.js:27524:28)
    at checkExpression (./node_modules/typescript/lib/typescript.js:27474:42)
    at checkNonNullExpression (./node_modules/typescript/lib/typescript.js:25030:24)
    at checkPropertyAccessExpressionOrQualifiedName (./node_modules/typescript/lib/typescript.js:25050:24)

[texastoland]

At first glance it looks like it's recursing having to do with flow analysis in statements like this.testStackOverflow = this.testStackOverflow.bind(this). Working on a minimal case now.

[texastoland]

@RyanCavanaugh I added a test to the description. I'll spend a few minutes to see whether I can spot the regression before I revert builds. CC @spicydonuts

[texastoland]

I couldn't find anything useful in the blame but here's what's happening:

• checkExpressionCached gets entered uncached.
• The righthand node traverses down to the testStackOverflow symbol.
• getTypeOfVariableOrParameterOrProperty checks its declarations.
• Its only declaration is the original expression being checked.
• checkExpressionCached recurses unresolved.

[texastoland]

I identified 1.9.0-dev.20160526-1.0 as the last passing build but didn't notice any suspect commits.