-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Performance regression in #33473 #36565
Copy link
Copy link
Open
Labels
Domain: PerformanceReports of unusually slow behaviorReports of unusually slow behaviorNeeds InvestigationThis issue needs a team member to investigate its status.This issue needs a team member to investigate its status.RescheduledThis issue was previously scheduled to an earlier milestoneThis issue was previously scheduled to an earlier milestone
Milestone
Metadata
Metadata
Assignees
Labels
Domain: PerformanceReports of unusually slow behaviorReports of unusually slow behaviorNeeds InvestigationThis issue needs a team member to investigate its status.This issue needs a team member to investigate its status.RescheduledThis issue was previously scheduled to an earlier milestoneThis issue was previously scheduled to an earlier milestone
Type
Fields
Give feedbackNo fields configured for issues without a type.
The extra work done in #33473 is valuable, but maybe it doesn't need to be so expensive. In this particular case, there don't seem to be any errors (though there is one
@ts-ignore).Setup:
yarnto restore packagesyarn typescriptto prebuild and run some TS testsRepro
tsc -p docsOn a random Mac Mini:
Note: to build old TS commits, you probably need to change
const { default: chalk }toconst chalkinscripts/build/utils.js.