Skip to content

Performance regression in #33473 #36565

@amcasey

Description

@amcasey

The extra work done in #33473 is valuable, but maybe it doesn't need to be so expensive. In this particular case, there don't seem to be any errors (though there is one @ts-ignore).

Setup:

  1. Clone https://github.com/amcasey/material-ui.git
  2. Check out Benchmark
  3. yarn to restore packages
  4. yarn typescript to prebuild and run some TS tests

Repro

  1. tsc -p docs

On a random Mac Mini:

  • 10-run avg on 6c2ae12: 33,010ms
  • 10-run avg on 26caa37: 33,494ms (1% slower)

Note: to build old TS commits, you probably need to change const { default: chalk } to const chalk in scripts/build/utils.js.

Metadata

Metadata

Assignees

Labels

Domain: PerformanceReports of unusually slow behaviorNeeds InvestigationThis issue needs a team member to investigate its status.RescheduledThis issue was previously scheduled to an earlier milestone

Type

No type
No fields configured for issues without a type.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions