[Copilot] Minor changes to the internals of OperationResponse and FunctionResponse - #928
Merged
Conversation
Gert Robyns (grobyns)
approved these changes
Apr 12, 2024
Darrick (darjoo)
enabled auto-merge (squash)
April 12, 2024 12:27
Sam (msft-sam)
approved these changes
Apr 12, 2024
Darrick (darjoo)
added a commit
that referenced
this pull request
May 2, 2024
…ctionResponse (#928) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Minor changes to the internals of OperationResponse and FunctionResponse. Conforming closer to facade principals #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#493212](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/493212)
Darrick (darjoo)
added a commit
that referenced
this pull request
May 6, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Backports of PRs #882 #928 #945 #719 #1037 #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#493212](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/493212) --------- Co-authored-by: Sun Haoran <haoransun@microsoft.com> Co-authored-by: Dmitry Katson <dmitry.katson@gmail.com>
Qasim (qasimikram)
pushed a commit
that referenced
this pull request
Jul 15, 2024
…ctionResponse (#928) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Minor changes to the internals of OperationResponse and FunctionResponse. Conforming closer to facade principals #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#493212](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/493212)
Qasim (qasimikram)
pushed a commit
that referenced
this pull request
Jul 15, 2024
…ctionResponse (#928) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Minor changes to the internals of OperationResponse and FunctionResponse. Conforming closer to facade principals #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#493212](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/493212)
Qasim (qasimikram)
added a commit
that referenced
this pull request
Jul 19, 2024
#### Summary Improvements done to marketing text feature by introduction functions and upgrading the model to gpt4o. The changes were merged into main as part of this PR #1275 This PR backports all the commits related to functions/tools that needs to be backported to make the above changes work in 24. Following are the list of commits that were cherry-picked in the same order: 1. #824 2. #882 3. #928 4. #945 5. #719 6. #1275 #### Work Item(s) Fixes # [AB#521281](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/521281) --------- Co-authored-by: Darrick <darjoo@users.noreply.github.com> Co-authored-by: Sun Haoran <haoransun@microsoft.com> Co-authored-by: Dmitry Katson <dmitry.katson@gmail.com> Co-authored-by: Qasim Ikram <qaikram@microsoft.com>
Qasim (qasimikram)
added a commit
that referenced
this pull request
Jul 19, 2024
#### Summary Improvements done to marketing text feature by introduction functions and upgrading the model to gpt4o. The changes were merged into main as part of this PR #1275 This PR backports all the commits related to functions/tools that needs to be backported to make the above changes work in 24. Following are the list of commits that were cherry-picked in the same order: 1. #824 2. #882 3. #928 4. #945 5. #719 6. #1275 #### Work Item(s) Fixes # [AB#521281](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/521281) --------- Co-authored-by: Darrick <darjoo@users.noreply.github.com> Co-authored-by: Sun Haoran <haoransun@microsoft.com> Co-authored-by: Dmitry Katson <dmitry.katson@gmail.com> Co-authored-by: Jesper Schulz-Wedde <JesperSchulz@users.noreply.github.com> Co-authored-by: Qasim Ikram <qaikram@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor changes to the internals of OperationResponse and FunctionResponse.
Conforming closer to facade principals
Work Item(s)
Fixes AB#493212