Consistent Changing No in Contract Line for Subscription Billing#4766
Merged
djukicmilica merged 2 commits intoSep 23, 2025
Merged
Conversation
Contributor
Author
|
Hi @samra-singhammer, if you can I would really appreciate a code review from your side on this one. |
AndersLarsenMicrosoft
previously approved these changes
Sep 16, 2025
AndersLarsenMicrosoft
left a comment
AndersLarsenMicrosoft
left a comment
Contributor
There was a problem hiding this comment.
looks good
anjajanic
reviewed
Sep 17, 2025
anjajanic
left a comment
anjajanic
left a comment
Contributor
There was a problem hiding this comment.
In the tests, I would use Asset.AreEqual(...) instead of Testfield.
Contributor
Author
done |
anjajanic
approved these changes
Sep 17, 2025
djukicmilica
approved these changes
Sep 17, 2025
AndersLarsenMicrosoft
approved these changes
Sep 23, 2025
This was referenced Oct 15, 2025
JesperSchulz
pushed a commit
that referenced
this pull request
Oct 16, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This is a backport of the PR: #4766 from main (28.0) to 27.x #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes #4444 Fixes [AB#608577](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/608577)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If an Item or a GL Account is changed in Customer Subscription Contract Line the Subscription that was previously connected to a Contract Line should either be deleted or disconnected from a contract line automatically.
Work Item(s)
Fixes #4444
Fixes AB#604192