Skip to content

[Shopify] Company mapping test are instable#4755

Merged
onbuyuka merged 4 commits into
mainfrom
bugs/602442-ShpfyInstability
Sep 23, 2025
Merged

[Shopify] Company mapping test are instable#4755
onbuyuka merged 4 commits into
mainfrom
bugs/602442-ShpfyInstability

Conversation

@onbuyuka

@onbuyuka onbuyuka commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Summary

Company mapping test are instable

Work Item(s)

Fixes AB#602442

@onbuyuka onbuyuka requested a review from a team as a code owner September 11, 2025 14:37
@github-actions github-actions Bot added this to the Version 28.0 milestone Sep 11, 2025
@onbuyuka onbuyuka enabled auto-merge (squash) September 11, 2025 14:40
JesperSchulz
JesperSchulz previously approved these changes Sep 11, 2025
Comment thread src/Apps/W1/Shopify/Test/Companies/ShpfyCompanyMappingTest.Codeunit.al Outdated

@grobyns grobyns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments you're free to ignore but the 1 place you call the helper with an Id <> 0 would still be unstable I think...

haoranpb
haoranpb previously approved these changes Sep 16, 2025
@onbuyuka onbuyuka dismissed stale reviews from haoranpb and JesperSchulz via 97225b3 September 16, 2025 14:52
haoranpb
haoranpb previously approved these changes Sep 16, 2025
WaelAbuSeada
WaelAbuSeada previously approved these changes Sep 16, 2025
grobyns
grobyns previously approved these changes Sep 16, 2025
@onbuyuka onbuyuka dismissed stale reviews from grobyns, WaelAbuSeada, and haoranpb via 99e8c15 September 16, 2025 20:18
@onbuyuka onbuyuka merged commit db99a74 into main Sep 23, 2025
26 checks passed
@onbuyuka onbuyuka deleted the bugs/602442-ShpfyInstability branch September 23, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants