[Bug]: Support for Mandatory Item Variants in Subscription Billing Module [SubscriptionBilling]#4662
Conversation
|
@anjajanic Can you do a code review please? |
pri-kise
left a comment
There was a problem hiding this comment.
I couldn't see any check on the variant blocked property.
e.g. when a variant is selected.
Is this intentional?
I know that this feature is still new for the variant (https://github.com/microsoft/BusinessCentralApps/pull/351).
Thanks, I wasn't aware this change coming in. I guess I would like to have it aligned. I will have another round then. |
pri-kise
left a comment
There was a problem hiding this comment.
I checked again some lines above and below your changes, since I was looking for the logic that updates the description with ItemVariant Translation (or the Description).
Maybe this code is already and I only don't see it.
Since this wasn't part of the original change, this don't need to be changed with this PR.
I'm only asking questions.
ce6d5c2 to
55b3c31
Compare
Head branch was pushed to by a user without write access
Summary
Work Item(s)
Fixes #4400
Fixes AB#604193