[24.x][PowerBI] Enable client resizing - #1645
Merged
Merged
Conversation
…zing (#1332) <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> This PR tackles a few minor limitations with the Power BI embedded experiences. Allows to set the token for the embed experience separately, removes unnecessary logic to tweak the size of the part hosting the add-in, allows to set more granular settings for the embed experience. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#538462](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/538462)
|
✅ Successfully linked to Azure Boards work item(s): |
Dawid Wozniak (dawidwoz)
approved these changes
Jul 25, 2024
Darrick (darjoo)
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a backport of a PR in main branch, and enables some additional options in the Power BI add-in. It also removes the logic to hardcode the height and width of the addin, allowing the client to decide on its size instead, for a much improved user experience.
Work Item(s)
Fixes AB#542753