Verify ordered 0→hero transcript#4716
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a focused make zero-to-hero-transcript target to validate (and CI-guard) the maintained, no-secret “0→hero” lifecycle transcript in a fixed order, and wires documentation/tests to ensure the transcript and references don’t drift.
Changes:
- Add a dedicated
zero-to-hero-transcriptMakefile target and havemake harnessinvoke it. - Enforce transcript step ordering by reordering the deploy dry-run step in the CI run script and adding an ordering test.
- Update README and the 0→hero guide to reference the focused target, and tighten doc-reference tests accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the new focused make zero-to-hero-transcript target alongside existing harness targets. |
| Makefile | Adds zero-to-hero-transcript target and hooks it into harness; updates help output. |
| internal/website/docs/guides/zero-to-hero.md | Adds the focused transcript target to the guide and entrypoint section. |
| internal/harness/zero-to-hero-ci/run.sh | Moves deploy dry-run to the end to match the intended lifecycle ordering. |
| internal/harness/zero-to-hero-ci/docs_test.go | Adds assertions that the new target exists, is referenced in docs/README, and that the transcript steps remain ordered. |
Comments suppressed due to low confidence (1)
internal/website/docs/guides/zero-to-hero.md:75
- The paragraph describing what “that target” runs is now inaccurate for
make zero-to-hero-transcript. The transcript target only executesinternal/harness/zero-to-hero-ci/run.sh(it does not runagent-floworprovider-conformance-mock, which are part ofmake harness). This will mislead readers about what the focused target actually covers.
That target runs the scaffold contract, the CLI boundary smoke tests, the
0→hero runtime harnesses, the event-driven agent-flow harness, and mock provider
conformance. It is intentionally deterministic: no provider key, cloud account,
SSH access, or remote service is required.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+89
to
+95
| makefile := readFile(t, filepath.Join(root, "Makefile")) | ||
| if !strings.Contains(makefile, "zero-to-hero-transcript:") { | ||
| t.Fatal("Makefile missing focused zero-to-hero-transcript target") | ||
| } | ||
| if !strings.Contains(makefile, "./internal/harness/zero-to-hero-ci/run.sh") { | ||
| t.Fatal("zero-to-hero-transcript target must run the maintained CI transcript") | ||
| } |
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
make zero-to-hero-transcripttarget for the maintained no-secret lifecycle transcript.Testing: