Preserve AtlasCloud conformance marker#4498
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a live AtlasCloud provider-conformance failure where a follow-up after a refused delegate tool call can omit the required agent-conformance marker from the final provider reply. It adds a small post-processing step to preserve the marker by re-attaching it from prior tool results when needed, and extends unit coverage for that scenario.
Changes:
- Wrap the follow-up final
Answerto ensure the conformance marker is preserved for refused-delegate follow-ups. - Add helper logic to detect refused delegate tool calls and append the marker from tool results when missing.
- Extend the follow-up tool-call unit test to assert the conformance marker is present in the final answer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ai/atlascloud/atlascloud.go | Appends conformance marker from tool results when a refused delegate follow-up reply omits it. |
| ai/atlascloud/atlascloud_test.go | Adds an assertion that the final answer preserves agent-conformance-ok in the refused-delegate follow-up path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+256
to
+260
| for _, result := range toolResults { | ||
| if strings.Contains(result, "agent-conformance") { | ||
| return strings.TrimSpace(answer + "\n" + result) | ||
| } | ||
| } |
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Testing:
Closes #4486
Closes #4497