Assorted tiny fixes and simplifications#866
Merged
Merged
Conversation
dnicolodi
force-pushed
the
fix/simplification
branch
from
8ed5df1 to
c24e292
Compare
dnicolodi
force-pushed
the
fix/simplification
branch
from
c24e292 to
37690cf
Compare
henryiii
reviewed
Jul 2, 2026
henryiii
approved these changes
Jul 2, 2026
rgommers
approved these changes
Jul 2, 2026
rgommers
left a comment
rgommers
left a comment
Contributor
There was a problem hiding this comment.
LGTM too, can be merged once the merge conflict is resolved.
The latter is available in Python > 3.9 and works well in all these instances and it is smaller and faster, and its use makes static analysis tools happier.
Having bumped the minimum Python version to 3.9, we can remove code that determined wheel tags for older Python versions.
dnicolodi
force-pushed
the
fix/simplification
branch
from
37690cf to
60d4b83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xred gh-861