added test if messurement of BME280Sensor was successfull fixes #11301 - #11302
added test if messurement of BME280Sensor was successfull fixes #11301#11302mcenderdragon wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@mcenderdragon, Welcome to Meshtastic!Thanks for opening your first pull request. We really appreciate it. We discuss work as a team in discord, please join us in the #firmware channel. Welcome to the team 😄 |
See issue #11301
I will test around if this fixes that issue, overall I think testing if the meassurment is successfull is needed. Also will need to test if millis() even works on the nRF or if the timeout never fires.
🤝 Attestations