Add Vale#11258
Conversation
MarkvanMents
left a comment
MarkvanMents
left a comment
There was a problem hiding this comment.
Looks great. Can't wait to try it out locally.
I've made a couple of suggestions - but we can always add/change things later as we get used to the tool
Thanks for doing this.
Mark.
|
|
||
| jobs: | ||
| vale: | ||
| # Only run on Mendix repo, not forks, and not on draft PRs |
There was a problem hiding this comment.
Does this mean it won't run on developer-submitted PRs?
Would it be better to run it on all PRs that target development?
Perhaps we can extend it to that if it is successful?
There was a problem hiding this comment.
Good point, and you're right—this will only include internal PRs rather than all PRs that target development. I think let's plan to expand it in a week if we're happy with how it's going?
| /.claude/audit.log | ||
| /.claude/settings.local.json | ||
| /.mcp.json | ||
| /.vale/styles/Microsoft/ |
There was a problem hiding this comment.
Is this something that the Vale package creates itself?
There was a problem hiding this comment.
Yes! It's the Microsoft package from Vale: https://github.com/vale-cli/packages#available-styles
| - JSON | ||
| - JSX | ||
| - LESS | ||
| - LLDB |
There was a problem hiding this comment.
Should we have MDA and MPR here? The acronyms don't actually make much sense (even if you can remember what they are). Are there any other Mendix acronyms which don't need explaining?
There was a problem hiding this comment.
I'll add those. I'm sure we will come up with more acronyms to add as we go along, so this will be a growing list.
| first: '\b([A-Z]{3,5})\b' | ||
| second: '(?:\b[A-Za-z][a-z]+ )+\(([A-Z]{3,5})\)' | ||
| # ... with the exception of these: | ||
| exceptions: |
There was a problem hiding this comment.
I presume this also covers jar and zip which I tend to see in lowercase.
There was a problem hiding this comment.
Yes, those won't be flagged—the regex only matches capitalized acronyms, so anything lowercase will just slip through.
|
|
||
| # Common individual words | ||
| '\bgrey\b': 'gray' | ||
| '\bwhilst\b': 'while' |
| 'data-set': 'dataset' | ||
| 'data set': 'dataset' | ||
| 'end point': 'endpoint' | ||
| 'check box': 'checkbox' |
There was a problem hiding this comment.
'end user': 'end-user'?
2 participants
No description provided.